Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-69138

Behat visit should be passed through $this->execute

    XMLWordPrintable

    Details

    • Story Points:
      0
    • Sprint:
      International 4.0 - Sprint 1, International 4.0 - Sprint 2

      Description

      There's a number of cases where we call $this->getSession()->visit($url) or similar and the we call steps immediately aftewards.

      In some steps we then immediately try to interact with the page - for example by pressing a button. This can cause random fails if the page has not yet finished loading.

      We have two options:

      1. add a call to $this->wait_for_pending_js(); or
      2. create a new i_visit step which call via $this->execute().

      My preference is for the new step, but then there are two further options:

      1. only update those cases affected; or
      2. update all, even those where it isn't necessary.

      Technically speaking we only need the $this->execute() where something is followed by another interaction before the end of the step, but it may be better to call the step consistently always.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              dobedobedoh Andrew Nicols
              Reporter:
              dobedobedoh Andrew Nicols
              Peer reviewer:
              Jun Pataleta
              Integrator:
              Adrian Greeve
              Tester:
              CiBoT
              Participants:
              Component watchers:
              Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                14/Sep/20

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 3 hours, 15 minutes
                  3h 15m