-
Improvement
-
Resolution: Fixed
-
Minor
-
3.5 regressions, 3.5.12, 3.7 regressions, 3.7.6, 3.8.3, 3.9
-
MOODLE_35_STABLE, MOODLE_37_STABLE, MOODLE_38_STABLE, MOODLE_39_STABLE
-
MOODLE_38_STABLE, MOODLE_39_STABLE
-
MDL-69138-master -
-
0
-
International 4.0 - Sprint 1, International 4.0 - Sprint 2
There's a number of cases where we call $this->getSession()->visit($url) or similar and the we call steps immediately aftewards.
In some steps we then immediately try to interact with the page - for example by pressing a button. This can cause random fails if the page has not yet finished loading.
We have two options:
- add a call to $this->wait_for_pending_js(); or
- create a new i_visit step which call via $this->execute().
My preference is for the new step, but then there are two further options:
- only update those cases affected; or
- update all, even those where it isn't necessary.
Technically speaking we only need the $this->execute() where something is followed by another interaction before the end of the step, but it may be better to call the step consistently always.