[MDL-69149] Invalid xpath in grade tests - Moodle Tracker

XML

Word

Printable

Details

Type: Improvement
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.5.12, 3.7.6, 3.8.3, 3.9
Fix Version/s: 3.5.13, 3.7.7, 3.8.4, 3.9.1
Component/s: Gradebook
Labels:
- ci
- triaged

Affected Branches:
MOODLE_35_STABLE, MOODLE_37_STABLE, MOODLE_38_STABLE, MOODLE_39_STABLE
Fixed Branches:
MOODLE_35_STABLE, MOODLE_37_STABLE, MOODLE_38_STABLE, MOODLE_39_STABLE
Pull from Repository:
git://github.com/andrewnicols/moodle.git
Pull 3.9 Branch:
~~MDL-69149~~-39
Pull 3.9 Diff URL:
https://github.com/andrewnicols/moodle/compare/89ce4db476...MDL-69149-39
Pull Master Branch:
~~MDL-69149~~-master
Pull Master Diff URL:
https://github.com/andrewnicols/moodle/compare/c11e2517a7...MDL-69149-master
Testing Instructions:
Hide

CI will test this but you can test it with
Run the following behat tests on CHrome and Firefox:

grade/tests/behat/grade_calculated_grade_items_20150627.feature
Show
CI will test this but you can test it with Run the following behat tests on CHrome and Firefox: grade/tests/behat/grade_calculated_grade_items_20150627.feature

Description

No idea why this doesn't fail on chrome or old firefox but it fails with newer versions of firefox.

We have an invalid xpath!

//input[@class='idnumber'][parent::li[@class='item'][text()='grade item 1'] | parent::li[@class='categoryitem' | @class='courseitem']/parent::ul/parent::li[starts-with(text(),'grade item 1')]]

The following part is invalid:

li[@class='categoryitem' | @class='courseitem']

You can't use a pipe for an attribute alternative.

Attachments

Issue Links

blocks

MDL-66979 Switch all the behat testing to the new W3C drivers

Closed

Activity

People

Assignee:: Andrew Lyons

Reporter:: Andrew Lyons

Peer reviewer:: Eloy Lafuente (stronk7)

Integrator:: Jake Dallimore

Tester:: CiBoT

Participants:: Andrew Lyons, CiBoT, Eloy Lafuente (stronk7), Jake Dallimore

Component watchers:: Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Sujith Haridasan

Votes:: 0 Vote for this issue

Watchers:: 4 Start watching this issue

Dates

Created:: 26/Jun/20 7:55 PM

Updated:: 04/Jul/20 1:02 AM

Resolved:: 04/Jul/20 1:02 AM

Fix Release Date:: 13/Jul/20

Time Tracking

Estimated:

Not Specified

Remaining:

Logged:

1h 15m