Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-69151

Airnotifier debugging breaks page output

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.8.3, 3.9, 3.9.1
    • Fix Version/s: 3.8.4, 3.9.1
    • Component/s: Other
    • Labels:
    • Testing Instructions:
      Hide

      Master

      1. Have an unregistered site
      2. Login as admin
      3. Turn on debugging
      4. Navigate to Messaging > Notification settings in site administration
      5. Under Notification plugins press Settings on the Mobile row
      6. Press Request access key
      7. Confirm the debugging is shown on the page similar to:

        Unexpected response from the Airnotifier server: {"error": "Site not registered on moodle.net"}
         
            line 145 of /message/output/airnotifier/classes/manager.php: call to debugging()
            line 67 of /message/output/airnotifier/requestaccesskey.php: call to message_airnotifier_manager->request_accesskey()
        

      Moodle 3.8

      1. Login as admin
      2. Turn on debugging
      3. Navigate to Site administration -> Messaging -> Notification settings
      4. Under Notification plugins press Settings on the Mobile row
      5. Change the airnotifierurl to https://example.com
      6. Save changes
      7. Press Request access key
      8. Confirm the debugging is shown on the page similar to:

         

        Unexpected response from the Airnotifier server: {"error": "Site not registered on moodle.net"}

      line 145 of /message/output/airnotifier/classes/manager.php: call to debugging()
      line 67 of /message/output/airnotifier/requestaccesskey.php: call to message_airnotifier_manager->request_accesskey()

      Show
      Master Have an unregistered site Login as admin Turn on debugging Navigate to Messaging > Notification settings in site administration Under Notification plugins press Settings on the Mobile row Press Request access key Confirm the debugging is shown on the page similar to: Unexpected response from the Airnotifier server: {"error": "Site not registered on moodle.net"}   line 145 of /message/output/airnotifier/classes/manager.php: call to debugging() line 67 of /message/output/airnotifier/requestaccesskey.php: call to message_airnotifier_manager->request_accesskey() Moodle 3.8 Login as admin Turn on debugging Navigate to Site administration -> Messaging -> Notification settings Under Notification plugins press Settings on the Mobile row Change the airnotifierurl to https://example.com Save changes Press Request access key Confirm the debugging is shown on the page similar to:   Unexpected response from the Airnotifier server: {"error": "Site not registered on moodle.net"} line 145 of /message/output/airnotifier/classes/manager.php: call to debugging() line 67 of /message/output/airnotifier/requestaccesskey.php: call to message_airnotifier_manager->request_accesskey()
    • Affected Branches:
      MOODLE_38_STABLE, MOODLE_39_STABLE
    • Fixed Branches:
      MOODLE_38_STABLE, MOODLE_39_STABLE
    • Pull Master Branch:

      Description

      Site admins won't be able to see the Airnotifier debugging messaging because it starts before the page output starts.

        Attachments

          Activity

            People

            Assignee:
            pholden Paul Holden
            Reporter:
            jleyva Juan Leyva
            Peer reviewer:
            Juan Leyva
            Integrator:
            Andrew Nicols
            Tester:
            Janelle Barcega
            Participants:
            Component watchers:
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              13/Jul/20

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 hour, 4 minutes
                1h 4m