[MDL-69151] Airnotifier debugging breaks page output - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.8.3, 3.9, 3.9.1
Fix Version/s: 3.8.4, 3.9.1
Component/s: Other
Labels:
- ci
- triaged

Affected Branches:
MOODLE_38_STABLE, MOODLE_39_STABLE
Fixed Branches:
MOODLE_38_STABLE, MOODLE_39_STABLE
Pull from Repository:
https://github.com/paulholden/moodle.git
Pull Master Branch:
~~MDL-69151~~
Pull Master Diff URL:
https://github.com/moodle/moodle/compare/master...paulholden:MDL-69151

Testing Instructions:

Hide

Master

Have an unregistered site
Login as admin
Turn on debugging
Navigate to Messaging > Notification settings in site administration
Under Notification plugins press Settings on the Mobile row
Press Request access key

Confirm the debugging is shown on the page similar to:

Unexpected response from the Airnotifier server: {"error": "Site not registered on moodle.net"}

    line 145 of /message/output/airnotifier/classes/manager.php: call to debugging()

    line 67 of /message/output/airnotifier/requestaccesskey.php: call to message_airnotifier_manager->request_accesskey()

Moodle 3.8

Login as admin
Turn on debugging
Navigate to Site administration -> Messaging -> Notification settings
Under Notification plugins press Settings on the Mobile row
Change the airnotifierurl to https://example.com
Save changes
Press Request access key
Confirm the debugging is shown on the page similar to:
Unexpected response from the Airnotifier server: {"error": "Site not registered on moodle.net"}

line 145 of /message/output/airnotifier/classes/manager.php: call to debugging()
line 67 of /message/output/airnotifier/requestaccesskey.php: call to message_airnotifier_manager->request_accesskey()

Show

Master Have an unregistered site Login as admin Turn on debugging Navigate to Messaging > Notification settings in site administration Under Notification plugins press Settings on the Mobile row Press Request access key Confirm the debugging is shown on the page similar to: Unexpected response from the Airnotifier server: {"error": "Site not registered on moodle.net"} line 145 of /message/output/airnotifier/classes/manager.php: call to debugging() line 67 of /message/output/airnotifier/requestaccesskey.php: call to message_airnotifier_manager->request_accesskey() Moodle 3.8 Login as admin Turn on debugging Navigate to Site administration -> Messaging -> Notification settings Under Notification plugins press Settings on the Mobile row Change the airnotifierurl to https://example.com Save changes Press Request access key Confirm the debugging is shown on the page similar to: Unexpected response from the Airnotifier server: {"error": "Site not registered on moodle.net"} line 145 of /message/output/airnotifier/classes/manager.php: call to debugging() line 67 of /message/output/airnotifier/requestaccesskey.php: call to message_airnotifier_manager->request_accesskey()

Description

Site admins won't be able to see the Airnotifier debugging messaging because it starts before the page output starts.

Attachments

Activity

People

Assignee:: Paul Holden

Reporter:: Juan Leyva

Peer reviewer:: Juan Leyva

Integrator:: Andrew Lyons

Tester:: Janelle Barcega

Participants:: Andrew Lyons, CiBoT, Juan Leyva, Paul Holden

Component watchers:: Adrian Greeve, David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo

Votes:: 0 Vote for this issue

Watchers:: 3 Start watching this issue

Dates

Created:: 27/Jun/20 12:37 AM

Updated:: 04/Jul/20 1:02 AM

Resolved:: 04/Jul/20 1:02 AM

Fix Release Date:: 13/Jul/20

Time Tracking

Estimated:

Not Specified

Remaining:

Logged:

1h 4m