[MDL-69202] Restore backup: add getter method for oldmoduleid - Moodle Tracker

XML

Word

Printable

Details

Type: Improvement
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.8.3, 3.9, 3.10
Fix Version/s: 3.11
Component/s: Backup
Labels:
- ci
- release_notes
- triaged

Affected Branches:
MOODLE_310_STABLE, MOODLE_38_STABLE, MOODLE_39_STABLE
Fixed Branches:
MOODLE_311_STABLE
Pull from Repository:
https://github.com/ffhs/moodle.git
Pull 3.11 Branch:
~~MDL-69202~~_311
Pull 3.11 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_311_STABLE..ffhs:MDL-69202_311
Pull Main Branch:
~~MDL-69202~~_master
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/master..ffhs:MDL-69202_master
Difficulty:
Easy
Testing Instructions:
Hide

Edit mod/lesson/backup/moodle2/restore_lesson_activity_task.class.php

Go down to after_restore() and add the following line anywhere that is not in an if statement: error_log('oldid: ' . $this->get_old_moduleid());

Save the file.

Go to a course with a lesson or create one.

Back up the lesson

open up the error log

tail -f /var/log/apache2/error.log (or something similar).

Restore the activity.

Once the restore is fully completed look through the error logs for "oldid". Confirm that there is a number next to it.
Show
Edit mod/lesson/backup/moodle2/restore_lesson_activity_task.class.php Go down to after_restore() and add the following line anywhere that is not in an if statement: error_log('oldid: ' . $this->get_old_moduleid()); Save the file. Go to a course with a lesson or create one. Back up the lesson open up the error log tail -f /var/log/apache2/error.log (or something similar). Restore the activity. Once the restore is fully completed look through the error logs for "oldid". Confirm that there is a number next to it.

Description

When using a restore class method for a plugin (<plugintype>\<pluginname>\backup\moodle2\restore_<plugintype>_<pluginname>_plugin.class.php), the task contains the oldmoduleid.

The information can be seen by $this->task->get_info();

But you can not access the oldmoduleid direct, as it's protected.

Therefore we should add here the missing getter method to access this variable if needed.

Attachments

Activity

People

Assignee:: Adrian Perez

Reporter:: Adrian Perez

Peer reviewer:: Peter Dias

Integrator:: Adrian Greeve

Tester:: Sujith Haridasan

Participants:: Adrian Greeve, Adrian Perez, CiBoT, Jake Dallimore, Peter Dias, Sujith Haridasan

Votes:: 0 Vote for this issue

Watchers:: 5 Start watching this issue

Dates

Created:: 04/Jul/20 5:54 PM

Updated:: 07/May/21 6:34 PM

Resolved:: 22/Jan/21 11:54 AM

Fix Release Date:: 17/May/21

Time Tracking

Estimated:

Remaining:

Logged:

2h 15m