Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-69246

Question manual grading: floating point issues can lead to valid grades being rejected

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Create a multiple choice with four possible answers:, single response question question with 4 choices:
        • Right answer (Grade 100%)
        • Wrong answer (Grade -33.3333333%)
        • Wrong answer (Grade -33.3333333%)
        • Wrong answer (Grade -33.3333333%)
      2. Add the question to a quiz
      3. From the Edit quiz page, change the question to be worth 0.75 (using the pencil on the right)
      4. Login as a student
      5. Attempt the quiz
      6. Choose the right answer.
      7. Login as a teacher
      8. Navigate to the quiz -> Attempts: 1
      9. From the table at the bottom, click "Review attempt" for the attempt just made
      10. Click "Make comment or override mark"
      11. Try to set the grade to values outside the allowed range -0.25 to 0.75.
        1. Verify that that the values are rejected (shown beneath the comment)
      12. Set the grade to -0.25.
        1. Verify that you are allowed to save it (no notice below the comment)
      Show
      Create a multiple choice with four possible answers:, single response question question with 4 choices: Right answer (Grade 100%) Wrong answer (Grade -33.3333333%) Wrong answer (Grade -33.3333333%) Wrong answer (Grade -33.3333333%) Add the question to a quiz From the Edit quiz page, change the question to be worth 0.75 (using the pencil on the right) Login as a student Attempt the quiz Choose the right answer. Login as a teacher Navigate to the quiz -> Attempts: 1 From the table at the bottom, click "Review attempt" for the attempt just made Click " Make comment or override mark " Try to set the grade to values outside the allowed range -0.25 to 0.75. Verify that that the values are rejected (shown beneath the comment) Set the grade to -0.25. Verify that you are allowed to save it (no notice below the comment)
    • Affected Branches:
      MOODLE_35_STABLE, MOODLE_37_STABLE, MOODLE_38_STABLE, MOODLE_39_STABLE
    • Fixed Branches:
      MOODLE_38_STABLE, MOODLE_39_STABLE
    • Pull from Repository:
    • Pull 3.9 Branch:
    • Pull 3.9 Diff URL:
    • Pull 3.10 Branch:
      MDL-69246_310
    • Pull 3.10 Diff URL:
    • Pull Master Branch:
    • Pull Master Diff URL:

      Description

      Steps to reproduce:

      1. Create a multiple choice, single response question question with 4 choices:
        • Right answer (100%)
        • Wrong answer (-33.3333333%)
        • Wrong answer (-33.3333333%)
        • Wrong answer (-33.3333333%)
      2. Add the question to a quiz - and set it to be worth 0.75 marks
      3. As student, attempt the quiz, and choose a wrong answer.
      4. As teacher, go in and try to manually override the grade.
      5. First set the grade to 0.75 and save.
      6. Then go back, and try to set the grade back to -0.25.

      Expected result: it works.

      Actual result: you are told that grade is out of range.

      Originally reported here: https://moodle.org/mod/forum/discuss.php?d=406658

        Attachments

          Activity

            People

            Assignee:
            timhunt Tim Hunt
            Reporter:
            timhunt Tim Hunt
            Peer reviewer:
            Eric Merrill Eric Merrill
            Integrator:
            Andrew Lyons Andrew Lyons
            Tester:
            Anna Carissa Sadia Anna Carissa Sadia
            Participants:
            Component watchers:
            Tim Hunt, Andrew Lyons, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
            Votes:
            2 Vote for this issue
            Watchers:
            6 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              14/Sep/20

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 hour, 43 minutes
                1h 43m