Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-69249

Turn editing on missing on settings block

    XMLWordPrintable

Details

    • Bug
    • Status: Open
    • Minor
    • Resolution: Unresolved
    • 3.9, 3.10, 3.11.3, 4.0
    • None
    • Navigation, Themes
    • MOODLE_310_STABLE, MOODLE_311_STABLE, MOODLE_39_STABLE, MOODLE_400_STABLE
    • wip_MDL-69249_master
    • Hide

      As the the class 'settings_navigation' cannot be overridden then no workaround is possible unless a soultion with extending the navigation is possible.

      Show
      As the the class 'settings_navigation' cannot be overridden then no workaround is possible unless a soultion with extending the navigation is possible.
      1. Select the 'Classic' theme.
      2. Navigate to a course where you have editing rights.
      3. Confirm that the 'Turn editing on' link is not listed under 'Course Administration' in the 'Administration' block.

    Description

      If a theme chooses to use the 'settings' block instead of flat navigation (Such as the popular Adaptable theme) then "Turn editing on" has been removed in the class 'settings_navigation' in 'lib/navigationlib.php' by MDL-67924 which was a change for the 'Boost' theme, however, that theme does not use the settings block so the impact could not have been anticipated to be beyond the scope of the intent of the improvement.  Thus the code in the navigationlib.php needs putting back and an alternative solution found.

      Thus missing:

      and this is the code:

      Attachments

        Issue Links

          is a regression caused by

          New Feature - A new Moodle feature which has yet to be developed. MDL-67924 Move turn editing on button out of the edit menu on boost

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Activity

            People

              Unassigned Unassigned
              gb2048 Gareth J Barnard
              David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo, Huong Nguyen, Bas Brands, Mathew May
              Votes:
              9 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

                Created:
                Updated:

                Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 hour, 25 minutes
                  1h 25m