Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-69249

Turn editing on missing on settings block

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Waiting for peer review
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 3.9, 3.10, 3.11.3, 4.0
    • Fix Version/s: None
    • Component/s: Navigation, Themes
    • Labels:
    • Affected Branches:
      MOODLE_310_STABLE, MOODLE_311_STABLE, MOODLE_39_STABLE, MOODLE_400_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      wip_MDL-69249_master
    • Workaround:
      Hide

      As the the class 'settings_navigation' cannot be overridden then no workaround is possible unless a soultion with extending the navigation is possible.

      Show
      As the the class 'settings_navigation' cannot be overridden then no workaround is possible unless a soultion with extending the navigation is possible.
    • Testing Instructions:
      1. Select the 'Classic' theme.
      2. Navigate to a course where you have editing rights.
      3. Confirm that the 'Turn editing on' link is not listed under 'Course Administration' in the 'Administration' block.

      Description

      If a theme chooses to use the 'settings' block instead of flat navigation (Such as the popular Adaptable theme) then "Turn editing on" has been removed in the class 'settings_navigation' in 'lib/navigationlib.php' by MDL-67924 which was a change for the 'Boost' theme, however, that theme does not use the settings block so the impact could not have been anticipated to be beyond the scope of the intent of the improvement.  Thus the code in the navigationlib.php needs putting back and an alternative solution found.

      Thus missing:

      and this is the code:

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              gb2048 Gareth J Barnard
              Reporter:
              gb2048 Gareth J Barnard
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan, Huong Nguyen, Bas Brands, Mathew May
              Votes:
              9 Vote for this issue
              Watchers:
              9 Start watching this issue

                Dates

                Created:
                Updated:

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 40 minutes
                  40m