Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-69252

Paging bar HTML invalid

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      1. Log into Moodle as a site admin.
      2. Navigate to Site administrationLanguageLanguage customisation.
      3. Select language pack (e.g. English (en)) in the drop-down list.
      4. Click Open language pack for editing.
      5. Click Continue when prompted.
      6. In Show strings of these components select every item (e.g. select the first item, scroll to the bottom of the last, then hold down shift and select the last item).
      7. Click Show strings.
      8. In the browser view the page source (e.g. right click, View Page Source in Firefox).
      9. Search for "…" (appears twice, in paging bar at top and bottom of results).
      10. Check that the containing <span> is closed correctly, i.e.:
      <span class="page-link">&hellip;</span>
      not:
      <span class="page-link">&hellip;</a>
      11. Close the page source view and return to the Language Customisation page in Moodle.
      12. In the paging bar click the link to go to the last page (page 290 on my system).
      13. Again view page source and search for "&hellip;".
      14. Again check that the containing <span> is closed correctly, i.e.:
      <span class="page-link">&hellip;</span>
      not:
      <span class="page-link">&hellip;</a>

      Show
      1. Log into Moodle as a site admin. 2. Navigate to Site administration → Language → Language customisation . 3. Select language pack (e.g. English (en) ) in the drop-down list. 4. Click Open language pack for editing . 5. Click Continue when prompted. 6. In Show strings of these components select every item (e.g. select the first item, scroll to the bottom of the last, then hold down shift and select the last item). 7. Click Show strings . 8. In the browser view the page source (e.g. right click, View Page Source in Firefox). 9. Search for "&hellip;" (appears twice, in paging bar at top and bottom of results). 10. Check that the containing <span> is closed correctly, i.e.: <span class="page-link">&hellip;</span> not: <span class="page-link">&hellip; </a> 11. Close the page source view and return to the Language Customisation page in Moodle. 12. In the paging bar click the link to go to the last page (page 290 on my system). 13. Again view page source and search for "&hellip;". 14. Again check that the containing <span> is closed correctly, i.e.: <span class="page-link">&hellip;</span> not: <span class="page-link">&hellip; </a>
    • Affected Branches:
      MOODLE_38_STABLE, MOODLE_39_STABLE
    • Fixed Branches:
      MOODLE_38_STABLE, MOODLE_39_STABLE
    • Pull from Repository:
    • Pull 3.8 Branch:
      MDL-69252-close_tag-38
    • Pull 3.9 Branch:
      MDL-69252-close_tag-39
    • Pull Master Branch:
      MDL-69252-close_tag

      Description

      lib/templates/paging_bar.mustache contains incorrect close tag on lines 17 and 32:

      17 <span class="page-link">…</a>

      32 <span class="page-link">…</a>

      This appears in the page source when the paging bar is used and the page count exceeded the maximum number of pagelinks to display so the ellipsis is shown.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              leonstr Leon Stringer
              Reporter:
              leonstr Leon Stringer
              Peer reviewer:
              Mihail Geshoski
              Integrator:
              Jun Pataleta
              Tester:
              Anna Carissa Sadia
              Participants:
              Component watchers:
              Amy Groshek, David Scotson, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                14/Sep/20

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 hour, 50 minutes
                  1h 50m