Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-69273

travis builds do not report phpunit failures/errors anymore

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 3.5.13, 3.7.7, 3.8.4, 3.9.1, 3.10, 4.0
    • 3.5.14, 3.7.8, 3.8.5, 3.9.2
    • Unit tests

    Description

      This seems to be a recent regression caused by MDL-66322

      Uh, oh... I think I've detected a regression of this.

      1) Do any tiny change forcing a unit test to fail (change 1 assertion, throw an exception...).
      2) Push to github and get travis testing it.
      3a) Expected result: the PHPUNIT jobs fails.
      3b) Current result: The PHPUNIT jobs end ok.

      Real example, I've a branch automatically run weekly, and known to be failing... and suddenly I got a mail from travis it had passed, I could not believe it! Looking to the logs you'll see it fails, errors... and not mater of that... it passes!

      Link: https://travis-ci.org/github/stronk7/moodle/builds/707981008

      Surely it's because the new line added after the phpunit execution "eats" its exit code, we need to fix that ASAP.

      Attachments

        Issue Links

          Activity

            People

              dobedobedoh Andrew Lyons
              stronk7 Eloy Lafuente (stronk7)
              Matteo Scaramuccia Matteo Scaramuccia
              Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
              CiBoT CiBoT
              Andrew Lyons, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              1 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                14/Sep/20

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 hour, 25 minutes
                  1h 25m