Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-69297

File-based Assignments shouldn't accept submissions without any files

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Confirm behat tests pass

      Prerequisites:

      1. A course with a teacher and student enrolled
      2. 3 assignments with 'Require students to click submit button - Yes' and the following submission setting (Note the ids for each assignment):
        1. File submissions - Assignment 1
        2. Text submissions - Assignment 2
        3. File/Text submissions - Assignment 3

      Testing:

      1. As a student, go to the course created
      2. In Assignment 1, upload a file and save changes
      3. Duplicate the current tab (Tab1 and Tab2) with both tabs indicating the assignment is still not submitted
      4. In Tab1, click and confirm remove submission
      5. In Tab2, click submit assignment and confirm
      6. Confirm you are provided a warning indicating an incomplete submission
      7. With the following URL {{mod/assign/view.php?id= {insert id here}

        &action=submit}} insert the ids for Assignment 2 and 3

      8. Repeat #6 with each assignment
      Show
      Confirm behat tests pass Prerequisites: A course with a teacher and student enrolled 3 assignments with 'Require students to click submit button - Yes' and the following submission setting (Note the ids for each assignment): File submissions - Assignment 1 Text submissions - Assignment 2 File/Text submissions - Assignment 3 Testing: As a student, go to the course created In Assignment 1, upload a file and save changes Duplicate the current tab (Tab1 and Tab2) with both tabs indicating the assignment is still not submitted In Tab1, click and confirm remove submission In Tab2, click submit assignment and confirm Confirm you are provided a warning indicating an incomplete submission With the following URL {{mod/assign/view.php?id= {insert id here} &action=submit}} insert the ids for Assignment 2 and 3 Repeat #6 with each assignment
    • Affected Branches:
      MOODLE_38_STABLE, MOODLE_39_STABLE
    • Fixed Branches:
      MOODLE_38_STABLE, MOODLE_39_STABLE
    • Pull from Repository:
    • Pull 3.9 Branch:
    • Pull Master Branch:
      MDL-69297-master
    • Story Points:
      1
    • Sprint:
      4.0 holding pattern 3, 4.0 holding pattern 4

      Description

      Steps to reproduce

      As a teacher:

      1. Create new assignment with:
      2. Submission types = File submissions
      3. Require students to click the submit button = Yes

      As a student:

      1. On the assignment, Edit submission:
      2. Upload a file and save changes
      3. Open the Assignment page (with the Submit assignment button) in two browser tabs
      4. In one of the tabs, click and confirm the "Remove submission" button (the submission now has no files)
      5. In the other tab, click Submit assignment and confirm.

      Expected results

      Moodle rejects the submission, due to checking and finding that it had no files.

      Actual results

      Moodle accepts the submission.

      Notes

      Obviously this is a slightly pathological case, as it must take some malevolence or considerable confusion for a student to take those steps and create an empty submission - but I've had a student that appears to have managed just that!

        Attachments

          Activity

            People

            Assignee:
            peterdias Peter Dias
            Reporter:
            balchd Dave Balch
            Peer reviewer:
            Mathew May Mathew May
            Integrator:
            Víctor Déniz Falcón Víctor Déniz Falcón
            Tester:
            Anna Carissa Sadia Anna Carissa Sadia
            Participants:
            Component watchers:
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
            Votes:
            1 Vote for this issue
            Watchers:
            8 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              14/Sep/20

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 day, 41 minutes
                1d 41m