[MDL-69311] Correct license docblock in dataformats class - Moodle Tracker

XML

Word

Printable

Details

Type: Task
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.9.1
Fix Version/s: 3.9.2
Component/s: Libraries
Labels:
- ci

Affected Branches:
MOODLE_39_STABLE
Fixed Branches:
MOODLE_39_STABLE
Pull from Repository:
https://github.com/paulholden/moodle.git
Pull 3.9 Branch:
~~MDL-69311~~-39
Pull 3.9 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_39_STABLE...paulholden:MDL-69311-39
Pull Master Branch:
~~MDL-69311~~
Pull Master Diff URL:
https://github.com/moodle/moodle/compare/master...paulholden:MDL-69311

Testing Instructions:

Hide

Open lib/classes/dataformat.php in an editor.
Confirm the absence of the incorrect license docblock.

Expected

/**

 * Class containing utility methods for dataformats

 * @package     core

 * @copyright   2020 Paul Holden <paulh@moodle.com>

 * @license     http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later

*/

Before patch

/**

* Class containing utility methods for dataformats

* @package     core

* @copyright   2020 Moodle Pty Ltd <support@moodle.com>

* @author      2020 Paul Holden <paulh@moodle.com>

* @copyright   2020 Paul Holden <paulh@moodle.com>

* @license     http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later

* @license     Moodle Workplace License, distribution is restricted, contact support@moodle.com

*/

Show

Open lib/classes/dataformat.php in an editor. Confirm the absence of the incorrect license docblock. Expected /** * Class containing utility methods for dataformats * * @package core * @copyright 2020 Paul Holden <paulh@moodle.com> * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later */ Before patch /** * Class containing utility methods for dataformats * * @package core * @copyright 2020 Moodle Pty Ltd <support@moodle.com> * @author 2020 Paul Holden <paulh@moodle.com> * @copyright 2020 Paul Holden <paulh@moodle.com> * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later * @license Moodle Workplace License, distribution is restricted, contact support@moodle.com */

Description

While working on ~~MDL-68500~~, I inadvertently added Workplace boilerplate license to a new class (found during internal code review)

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

image-2020-08-06-10-08-22-207.png
75 kB
06/Aug/20 10:08 AM

Activity

People

Assignee:: Paul Holden

Reporter:: Paul Holden

Peer reviewer:: Simey Lameze

Integrator:: Adrian Greeve

Tester:: Janelle Barcega

Participants:: Adrian Greeve, CiBoT, Janelle Barcega, Paul Holden, Simey Lameze

Component watchers:: David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo

Votes:: 0 Vote for this issue

Watchers:: 4 Start watching this issue

Dates

Created:: 17/Jul/20 11:22 PM

Updated:: 07/Aug/20 3:13 AM

Resolved:: 07/Aug/20 3:13 AM

Fix Release Date:: 14/Sep/20

Time Tracking

Estimated:

Not Specified

Remaining:

Logged:

54m