Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-69311

Correct license docblock in dataformats class

    XMLWordPrintable

    Details

    • Type: Task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.9.1
    • Fix Version/s: 3.9.2
    • Component/s: Libraries
    • Labels:
    • Testing Instructions:
      Hide
      1. Open lib/classes/dataformat.php in an editor.
      2. Confirm the absence of the incorrect license docblock.

      Expected

      /**
       * Class containing utility methods for dataformats
       *
       * @package     core
       * @copyright   2020 Paul Holden <paulh@moodle.com>
       * @license     http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
       */
      

      Before patch

      /**
      * Class containing utility methods for dataformats
      *
      * @package     core
      * @copyright   2020 Moodle Pty Ltd <support@moodle.com>
      * @author      2020 Paul Holden <paulh@moodle.com>
      * @copyright   2020 Paul Holden <paulh@moodle.com>
      * @license     http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
      * @license     Moodle Workplace License, distribution is restricted, contact support@moodle.com
      */
      

      Show
      Open lib/classes/dataformat.php in an editor. Confirm the absence of the incorrect license docblock. Expected /** * Class containing utility methods for dataformats * * @package core * @copyright 2020 Paul Holden <paulh@moodle.com> * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later */ Before patch /** * Class containing utility methods for dataformats * * @package core * @copyright 2020 Moodle Pty Ltd <support@moodle.com> * @author 2020 Paul Holden <paulh@moodle.com> * @copyright 2020 Paul Holden <paulh@moodle.com> * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later * @license Moodle Workplace License, distribution is restricted, contact support@moodle.com */
    • Affected Branches:
      MOODLE_39_STABLE
    • Fixed Branches:
      MOODLE_39_STABLE
    • Pull 3.9 Branch:
    • Pull Master Branch:

      Description

      While working on MDL-68500, I inadvertently added Workplace boilerplate license to a new class (found during internal code review)

        Attachments

          Activity

            People

            Assignee:
            pholden Paul Holden
            Reporter:
            pholden Paul Holden
            Peer reviewer:
            Simey Lameze
            Integrator:
            Adrian Greeve
            Tester:
            Janelle Barcega
            Participants:
            Component watchers:
            Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              14/Sep/20

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 54 minutes
                54m