Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-69319

LTI external tests clean up

    XMLWordPrintable

Details

    • 1
    • 4.0 holding pattern 3

    Description

      There are a few issues here which should be fixed:

      1. A number of the tests for external.php in mod/lti/tests/externallib_test.php don't clean the return value before making assertions about the return. We should always call clean_returnvalue().

      2. The test exploits the setUp method to create courses and enrolments which are then only used in a couple of tests. This should be achieved via a helper method instead.

      3. A number of tests check for exceptional behaviour using a try/catch in the test. We should replace this with expectException() calls.

      4. There are a number of unused vars.

      Attachments

        Issue Links

          Activity

            People

              jaked Jake Dallimore
              jaked Jake Dallimore
              Mihail Geshoski Mihail Geshoski
              Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
              CiBoT CiBoT
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 3 hours
                  3h

                  Clockify

                    Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.