Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 3.5.13, 3.7.7, 3.8.4, 3.9.1, 3.10
-
Component/s: External Tool (IMS-LTI)
-
Labels:
-
Testing Instructions:
-
Affected Branches:MOODLE_310_STABLE, MOODLE_35_STABLE, MOODLE_37_STABLE, MOODLE_38_STABLE, MOODLE_39_STABLE
-
Fixed Branches:MOODLE_35_STABLE, MOODLE_37_STABLE, MOODLE_38_STABLE, MOODLE_39_STABLE
-
Pull from Repository:
-
Pull 3.5 Branch:
MDL-69319-35 -
Pull 3.5 Diff URL:
-
Pull 3.8 Branch:
MDL-69319-38 -
Pull 3.8 Diff URL:
-
Pull 3.9 Branch:
MDL-69319-39 -
Pull 3.9 Diff URL:
-
Pull Master Branch:
MDL-69319-master -
Pull Master Diff URL:
-
Story Points:1
-
Sprint:4.0 holding pattern 3
Description
There are a few issues here which should be fixed:
1. A number of the tests for external.php in mod/lti/tests/externallib_test.php don't clean the return value before making assertions about the return. We should always call clean_returnvalue().
2. The test exploits the setUp method to create courses and enrolments which are then only used in a couple of tests. This should be achieved via a helper method instead.
3. A number of tests check for exceptional behaviour using a try/catch in the test. We should replace this with expectException() calls.
4. There are a number of unused vars.
Attachments
Issue Links
- blocks
-
-
- Closed
-
