Details
-
Bug
-
Status: Closed
-
Minor
-
Resolution: Fixed
-
3.5.13, 3.7.7, 3.8.4, 3.9.1, 3.10
-
1
-
4.0 holding pattern 3
Description
There are a few issues here which should be fixed:
1. A number of the tests for external.php in mod/lti/tests/externallib_test.php don't clean the return value before making assertions about the return. We should always call clean_returnvalue().
2. The test exploits the setUp method to create courses and enrolments which are then only used in a couple of tests. This should be achieved via a helper method instead.
3. A number of tests check for exceptional behaviour using a try/catch in the test. We should replace this with expectException() calls.
4. There are a number of unused vars.
Attachments
Issue Links
- blocks
-
MDL-67695 External tool page error
-
- Closed
-