Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-69336

Collapsing columns in dynamic tables no longer functions

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Prerequisites

      1. Have a course set up with some students and a teacher enrolled.

      Testing

      1. Log in as the teacher.
      2. Navigate to the participants page of the course, wait a few seconds to ensure all content has loaded.
      3. Open the browser console (eg in Firefox press ctrl+shift+k).
      4. In the participants table, click on the "-" (hide) icon under a few of the table headings (such as name, role, email address).
      5. CONFIRM those columns become hidden in the table.
      6. CONFIRM no errors appeared in the console when you hid the columns.
      7. Press the "+" (show) icons for the columns you previously hid.
      8. CONFIRM the columns re-appear.
      9. CONFIRM the widths of the columns are correct (ie the same as they were before being hidden and not really narrow/wrapping).
      10. CONFIRM no errors appeared in the console when you un-hid the columns.

      Note: The hiding/showing of columns are now also covered by unit tests, but manual testing confirms the JS console errors and column widths have been corrected.

      Show
      Prerequisites Have a course set up with some students and a teacher enrolled. Testing Log in as the teacher. Navigate to the participants page of the course, wait a few seconds to ensure all content has loaded. Open the browser console (eg in Firefox press ctrl+shift+k). In the participants table, click on the "-" (hide) icon under a few of the table headings (such as name, role, email address). CONFIRM those columns become hidden in the table. CONFIRM no errors appeared in the console when you hid the columns. Press the "+" (show) icons for the columns you previously hid. CONFIRM the columns re-appear. CONFIRM the widths of the columns are correct (ie the same as they were before being hidden and not really narrow/wrapping). CONFIRM no errors appeared in the console when you un-hid the columns. Note: The hiding/showing of columns are now also covered by unit tests, but manual testing confirms the JS console errors and column widths have been corrected.
    • Affected Branches:
      MOODLE_39_STABLE
    • Fixed Branches:
      MOODLE_39_STABLE
    • Pull 3.9 Branch:
    • Pull Master Branch:
      MDL-69336-master
    • Story Points:
      0
    • Sprint:
      International 4.0 - Sprint 2, International 4.0 - Sprint 3

      Description

      When clicking the icons to collapse columns (such as on the course participants page), the request is sent, but no change is made to the table.

      It appears that when some code was refactored so that resetting table preferences became dynamic, the call to set the hiding preferences was accidentally removed, so the request is received, but nothing in the backend actions the hiding of the column(s).

      It appears that $this->set_hide_show_preferences() needs to be called where the other preferences are being set, however that doesn't seem to be a complete fix, because un-hiding hidden columns results in their widths being too narrow, which will also need to be corrected.

      There is also a JS error being thrown in the console after hiding/un-hiding columns.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              michaelh Michael Hawkins
              Reporter:
              michaelh Michael Hawkins
              Peer reviewer:
              Ferran Recio
              Integrator:
              Jun Pataleta
              Tester:
              Janelle Barcega
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                14/Sep/20

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 day, 3 hours, 38 minutes
                  1d 3h 38m