Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-69356

PHPUnit failures caused by unix expected dir separators under windows

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.10
    • Fix Version/s: 3.10
    • Component/s: Unit tests
    • Labels:

      Description

      It has been detected that MDL-68874 introduced some tests dependent of OS directory separators (DIRECTORY_SEPARATOR) and/or end of line chars (PHP_EOL).

      $ vendor/bin/phpunit core_dml_testcase lib/dml/tests/dml_test.php
      Moodle 4.0dev (Build: 20200723), 94fdac9117db2fd0f2d999f0bdd822fab6193e52
      Php: 7.3.5, pgsql: 10.6, OS: Windows NT 10.0 AMD64
      PHPUnit 7.5.20 by Sebastian Bergmann and contributors.
       
      .....F.........................................................  63 / 105 ( 60%)
      ..........................................                      105 / 105 (100%)
       
      Time: 15.81 seconds, Memory: 48.00 MB
       
      There was 1 failure:
       
      1) core_dml_testcase::test_add_sql_debugging
      Failed asserting that two strings are equal.
      --- Expected
      +++ Actual
      @@ @@
       'SELECT * FROM {users}\n
      --- line 65 of /lib/dml/tests/fixtures/test_dml_sql_debugging_fixture.php: call to ReflectionMethod->invoke()'
      +-- line 65 of \lib\dml\tests\fixtures\test_dml_sql_debugging_fixture.php: call to ReflectionMethod->invoke()'
       
      C:\Users\stronk7\git_moodle\integration\lib\dml\tests\dml_test.php:464
      C:\Users\stronk7\git_moodle\integration\lib\phpunit\classes\database_driver_testcase.php:143
       
      To re-run:
       vendor/bin/phpunit "core_dml_testcase" lib/dml/tests/dml_test.php
       
      FAILURES!
      Tests: 105, Assertions: 1208, Failures: 1.
      

      This issue is about to make the tests cross-os, without modifying the codebase because it's assumed to be correct.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              stronk7 Eloy Lafuente (stronk7)
              Reporter:
              stronk7 Eloy Lafuente (stronk7)
              Peer reviewer:
              Tim Hunt
              Integrator:
              Andrew Nicols
              Tester:
              Shamim Rezaie
              Participants:
              Component watchers:
              Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                9/Nov/20

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 2 hours, 20 minutes
                  2h 20m