Details
-
Bug
-
Status: Closed
-
Minor
-
Resolution: Fixed
-
3.10
-
MOODLE_310_STABLE
-
MOODLE_310_STABLE
-
- Run vendor/bin/phpunit core_dml_testcase lib/dml/tests/dml_test.php under unix and windows.
- Verify if passes without any core_dml_testcase::test_add_sql_debugging failure.
Description
It has been detected that MDL-68874 introduced some tests dependent of OS directory separators (DIRECTORY_SEPARATOR) and/or end of line chars (PHP_EOL).
$ vendor/bin/phpunit core_dml_testcase lib/dml/tests/dml_test.php
|
Moodle 4.0dev (Build: 20200723), 94fdac9117db2fd0f2d999f0bdd822fab6193e52
|
Php: 7.3.5, pgsql: 10.6, OS: Windows NT 10.0 AMD64
|
PHPUnit 7.5.20 by Sebastian Bergmann and contributors.
|
|
|
.....F......................................................... 63 / 105 ( 60%)
|
.......................................... 105 / 105 (100%)
|
|
|
Time: 15.81 seconds, Memory: 48.00 MB
|
|
|
There was 1 failure:
|
|
|
1) core_dml_testcase::test_add_sql_debugging
|
Failed asserting that two strings are equal.
|
--- Expected
|
+++ Actual
|
@@ @@
|
'SELECT * FROM {users}\n
|
--- line 65 of /lib/dml/tests/fixtures/test_dml_sql_debugging_fixture.php: call to ReflectionMethod->invoke()'
|
+-- line 65 of \lib\dml\tests\fixtures\test_dml_sql_debugging_fixture.php: call to ReflectionMethod->invoke()'
|
|
|
C:\Users\stronk7\git_moodle\integration\lib\dml\tests\dml_test.php:464
|
C:\Users\stronk7\git_moodle\integration\lib\phpunit\classes\database_driver_testcase.php:143
|
|
|
To re-run:
|
vendor/bin/phpunit "core_dml_testcase" lib/dml/tests/dml_test.php
|
|
|
FAILURES!
|
Tests: 105, Assertions: 1208, Failures: 1.
|
This issue is about to make the tests cross-os, without modifying the codebase because it's assumed to be correct.
Attachments
Issue Links
- is a regression caused by
-
MDL-68874 Debug option to instrument SQL queries with the PHP code line/stack-trace for better logging
-
- Closed
-
