Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-69375

LTI Names and Roles Provisioning Service generates Link headers with incorrect format

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      pre-requisite

      1. LTI Advantage requires your site to be reachable from the internet. If not, Install ngrok to expose your moodle setup externally. Refer here for additional guidelines
      2. Have a course with an instructor and at least 5 other members, the test will only use pagination if there are more then 5 members in the course.
      3. As admin install the LTI Robotest test app using the instructions found at https://robotest.theedtech.dev
      4. Tool configuration usage: Show in activity chooser and as preconfigured tool

      Test: members count is shown accurately

      1. Enter a course as instructor
      2. Turn editing on
      3. Add external activity, choose Robotest app
      4. Click Select Content
        1. On Robotest App, choose add not graded activity
        2. Once back on the external tool editor, select Save and Display
      5. Verify:
        1. The robotest app displays without error
        2. The Members loaded is green
      Show
      pre-requisite LTI Advantage requires your site to be reachable from the internet. If not, Install ngrok to expose your moodle setup externally. Refer here for additional guidelines Have a course with an instructor and at least 5 other members, the test will only use pagination if there are more then 5 members in the course . As admin install the LTI Robotest test app using the instructions found at https://robotest.theedtech.dev Tool configuration usage: Show in activity chooser and as preconfigured tool Test: members count is shown accurately Enter a course as instructor Turn editing on Add external activity, choose Robotest app Click Select Content On Robotest App, choose add not graded activity Once back on the external tool editor, select Save and Display Verify: The robotest app displays without error The Members loaded is green
    • Affected Branches:
      MOODLE_310_STABLE, MOODLE_37_STABLE, MOODLE_38_STABLE, MOODLE_39_STABLE
    • Fixed Branches:
      MOODLE_38_STABLE, MOODLE_39_STABLE
    • Pull from Repository:
    • Pull 3.8 Branch:
    • Pull 3.9 Branch:
    • Pull Master Branch:

      Description

      The LTI Names and Roles Provisioning Service should return a correctly formatted Link header whenever it needs to inform a Tool Provider of the existence of additional Member pages.

      The correct Link header format according to RFC8288 is :

      Moodle's current Link header format is:

      Most link header parsers respect the specification, which causes Moodle's Names and Roles Link headers to be discarded, preventing the access to multiple Member pages.

      The fix is very simple and only involves one line of code: https://github.com/moodle/moodle/compare/master...Cvmcosta:MDL-69375

        Attachments

          Activity

            People

            Assignee:
            cvmcosta Carlos Costa
            Reporter:
            cvmcosta Carlos Costa
            Peer reviewer:
            Mathew May
            Integrator:
            Andrew Nicols
            Tester:
            Víctor Déniz Falcón
            Participants:
            Component watchers:
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
            Votes:
            0 Vote for this issue
            Watchers:
            8 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              14/Sep/20

                Time Tracking

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 4 hours, 56 minutes
                4h 56m