Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-69381

Course copy progress bar CSS selector in the javascript file is not specific enough

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Test 1 (regression check)

      1. Go to course management interface
      2. Press "copy course" next to any course
      3. Fill the form and press "Copy and view"
      4. Make sure the progress bar is displayed
      5. Run cron from command line or from another tab (if it does not run automatically on your instance)
      6. Make sure the progress bar changed to a tick

      Test 2

      1. Go to Site administration>Appearance>AdditionalHTML and add something like this to the $CFG->additionalhtmltopofbody : <div class="progress"><div class="progress-bar">Pseudo progress</div></div>
      2. Go to course management interface
      3. Press "copy course" next to any course
      4. Fill the form and press "Copy and view"
      5. Make sure the progress bar is displayed
      6. Open the "Network" tab and make sure that there are requests to the server (every second) and they do not return any errors, they also must only send one element in the 'copies' array
      7. Run cron from command line or from another tab (if it does not run automatically on your instance)
      8. Make sure the progress bar changed to a tick
      Show
      Test 1 (regression check) Go to course management interface Press "copy course" next to any course Fill the form and press "Copy and view" Make sure the progress bar is displayed Run cron from command line or from another tab (if it does not run automatically on your instance) Make sure the progress bar changed to a tick Test 2 Go to Site administration>Appearance>AdditionalHTML and add something like this to the $CFG->additionalhtmltopofbody : <div class="progress"><div class="progress-bar">Pseudo progress</div></div> Go to course management interface Press "copy course" next to any course Fill the form and press "Copy and view" Make sure the progress bar is displayed Open the "Network" tab and make sure that there are requests to the server (every second) and they do not return any errors, they also must only send one element in the 'copies' array Run cron from command line or from another tab (if it does not run automatically on your instance) Make sure the progress bar changed to a tick
    • Affected Branches:
      MOODLE_310_STABLE, MOODLE_39_STABLE
    • Fixed Branches:
      MOODLE_39_STABLE
    • Pull 3.9 Branch:
    • Pull Master Branch:

      Description

      In the Workplace theme we have other progress bars (in the user menu), so when waiting for course copy to complete we get web service exception. I traced it down to the progress bar selector in the JS being way too broad

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              marina Marina Glancy
              Reporter:
              marina Marina Glancy
              Peer reviewer:
              Simey Lameze
              Integrator:
              Andrew Nicols
              Tester:
              Anna Carissa Sadia
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                14/Sep/20

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 3 hours, 49 minutes
                  3h 49m