[MDL-69411] Invalid response when passing a timefrom higher than last message timecreated in get_conversation_messages - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.9.1, 3.10
Fix Version/s: 3.9.4, 3.10.1
Component/s: Messages, Web Services
Labels:

Testing Instructions:

Hide

Covered by PHPUnit

vendor/bin/phpunit --filter test_get_conversation_messages_timefrom_higher_than_last_timecreated message/tests/externallib_test.php

vendor/bin/phpunit --filter test_get_conversation_messages_timefrom_higher_than_last_timecreated message/tests/api_test.php

Show
Covered by PHPUnit vendor/bin/phpunit --filter test_get_conversation_messages_timefrom_higher_than_last_timecreated message/tests/externallib_test.php vendor/bin/phpunit --filter test_get_conversation_messages_timefrom_higher_than_last_timecreated message/tests/api_test.php
Affected Branches:
MOODLE_310_STABLE, MOODLE_39_STABLE
Fixed Branches:
MOODLE_310_STABLE, MOODLE_39_STABLE
Pull from Repository:
git://github.com/dravek/moodle.git
Pull 3.9 Branch:
~~MDL-69411~~-39
Pull 3.9 Diff URL:
https://github.com/dravek/moodle/compare/87bcff8c6e...MDL-69411-39
Pull 3.10 Branch:
~~MDL-69411~~-310
Pull 3.10 Diff URL:
https://github.com/dravek/moodle/compare/03e3219884...MDL-69411-310
Pull 3.11 Branch:
~~MDL-69411~~-311
Pull 3.11 Diff URL:
https://github.com/dravek/moodle/compare/ae8e7f90ad...MDL-69411-311
Pull Master Branch:
~~MDL-69411~~-master
Pull Master Diff URL:
https://github.com/dravek/moodle/compare/c8d33eb9ce...MDL-69411-master

Sprint:
Moppies Kanban

Description

This error is caused by this line of code. If there are no new messages after the timefrom param, it returns an empty array. However, the WebService core_message_get_conversation_messages expects to return this structure instead of an array.

Attachments

Activity

People

Assignee:: David Matamoros

Reporter:: Dani Palou

Peer reviewer:: Paul Holden

Integrator:: Jake Dallimore

Tester:: CiBoT

Participants:: CiBoT, Dani Palou, David Matamoros, Jake Dallimore, Paul Holden

Component watchers:: Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona), Juan Leyva, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)

Votes:: 0 Vote for this issue

Watchers:: 4 Start watching this issue

Dates

Created:: 05/Aug/20 6:43 PM

Updated:: 04/Dec/20 11:17 AM

Resolved:: 04/Dec/20 11:17 AM

Fix Release Date:: 18/Jan/21

Time Tracking

Estimated:

Remaining:

Logged:

1h 21m