Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-69411

Invalid response when passing a timefrom higher than last message timecreated in get_conversation_messages

XMLWordPrintable

    • MOODLE_310_STABLE, MOODLE_39_STABLE
    • MOODLE_310_STABLE, MOODLE_39_STABLE
    • MDL-69411-master
    • Hide

      Covered by PHPUnit

       

      vendor/bin/phpunit --filter test_get_conversation_messages_timefrom_higher_than_last_timecreated message/tests/externallib_test.php

      vendor/bin/phpunit --filter test_get_conversation_messages_timefrom_higher_than_last_timecreated message/tests/api_test.php

      Show
      Covered by PHPUnit   vendor/bin/phpunit --filter test_get_conversation_messages_timefrom_higher_than_last_timecreated message/tests/externallib_test.php vendor/bin/phpunit --filter test_get_conversation_messages_timefrom_higher_than_last_timecreated message/tests/api_test.php
    • Moppies Kanban

      This error is caused by this line of code. If there are no new messages after the timefrom param, it returns an empty array. However, the WebService core_message_get_conversation_messages expects to return this structure instead of an array.

            davidcarrillo David Carrillo
            dpalou Dani Palou
            Paul Holden Paul Holden
            Jake Dallimore Jake Dallimore
            CiBoT CiBoT
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 hour, 21 minutes
                1h 21m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.