Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-69422

HTML validation and accessibility problems on database export page

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      Setup
      1. Create a database activity.
      2. Define some fields with different field types.
      3. Go to the export page.
      HTML Validation
      1. View and copy the page source.
      2. Paste the page source in the text input field in the Nu HTML validator
      3. Check the HTML.
      4. Confirm that you don't see the following errors:
        • Element div not allowed as child of element span in this context.
        • The acronym element is obsolete. Use the abbr element instead.
        • Duplicate ID id_notice.
        • Element div not allowed as child of element label in this context.
          Note: You might see "An img element must have an alt attribute, except under certain conditions." related to the user profile pic, but this is an unrelated issue.
      Accessibility checkers
      1. Run axe on the page
      2. Confirm that you don't see any of the following errors:
        • IDs used in ARIA and labels must be unique
        • Form elements must have labels
          Note: You might see an error about multiple labels for the checkbox elements, but this is a separate issue and will be fixed in MDL-70288.
      Show
      Setup Create a database activity. Define some fields with different field types. Go to the export page. HTML Validation View and copy the page source. Paste the page source in the text input field in the Nu HTML validator Check the HTML. Confirm that you don't see the following errors: Element div not allowed as child of element span in this context. The acronym element is obsolete. Use the abbr element instead. Duplicate ID id_notice. Element div not allowed as child of element label in this context. Note: You might see " An img element must have an alt attribute, except under certain conditions. " related to the user profile pic, but this is an unrelated issue. Accessibility checkers Run axe on the page Confirm that you don't see any of the following errors: IDs used in ARIA and labels must be unique Form elements must have labels Note: You might see an error about multiple labels for the checkbox elements, but this is a separate issue and will be fixed in MDL-70288 .
    • Affected Branches:
      MOODLE_310_STABLE, MOODLE_39_STABLE
    • Fixed Branches:
      MOODLE_310_STABLE, MOODLE_39_STABLE
    • Pull 3.9 Branch:
      MDL-69422-39-2
    • Pull 3.10 Branch:
      MDL-69422-310-2
    • Pull 3.11 Branch:
      MDL-69422-311-2
    • Pull Master Branch:
      MDL-69422-master-2
    • Story Points:
      0
    • Sprint:
      International 4.0 - Sprint 7, Internationals - 3.11 Sprint 1, Internationals - 3.11 Sprint 2, Internationals - 3.11 Sprint 3

      Description

      https://school.moodledemo.net/mod/data/export.php?d=26

      On this page id=id_notice is used twice.  Element IDs must be unique. This is a violation of WCAG 2.1 success criterion 4.1.1 - Parsing.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              jpataleta Jun Pataleta
              Reporter:
              JuliaRie Julia Rietveld - Zjochova
              Peer reviewer:
              Shamim Rezaie Shamim Rezaie
              Integrator:
              Jake Dallimore Jake Dallimore
              Tester:
              Janelle Barcega Janelle Barcega
              Participants:
              Component watchers:
              Andrew Lyons, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                18/Jan/21

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 day, 4 hours, 39 minutes
                  1d 4h 39m