Loading...

XML

Word

Printable

Affected Branches:
MOODLE_310_STABLE, MOODLE_38_STABLE, MOODLE_39_STABLE
Fixed Branches:
MOODLE_39_STABLE
Pull from Repository:
git://github.com/bmbrands/moodle.git
Pull Main Branch:
~~MDL-69453~~-master
Pull Main Diff URL:
https://github.com/bmbrands/moodle/compare/d330035f11...MDL-69453-master
Testing Instructions:
Hide

Please test in themes Boost and Classic.

Test normal, required fields, fields with help

Install the attached file formstest.php in your Moodle root

Navigate to the formstest.php page

Click the "Show with both" link in the alert box
#Verify the required icon and help icon are aligned

Change your browser size to small (max 525px wide)

Verify the required icon and the help icon are aligned and displayed right after the form label
Show
Please test in themes Boost and Classic. Test normal, required fields, fields with help Install the attached file formstest.php in your Moodle root Navigate to the formstest.php page Click the "Show with both" link in the alert box # Verify the required icon and help icon are aligned Change your browser size to small (max 525px wide) Verify the required icon and the help icon are aligned and displayed right after the form label

The alignment of icons on form fields is a bit off. When the help and required icons are shown they are not aligned very well.

The advanced icon does not really mean anything since the show advanced feature has been removed in ~~MDL-30640~~.

When hovering over the required icon a question mark is shown which is a bit weird.

The current form field icons for Moodle forms are:

has a non-specific relationship to

MDLSITE-6400 Coding style/backwards compatibility: We need a rule to stop unnecessary HTML changes on stable branches which break themes

is child of

MDL-30640 Remove 'Advanced field' form functionality

Participants:: Adrian Greeve, Bas Brands, CiBoT, Eloy Lafuente (stronk7), Luca Bösch, Shamim Rezaie, Tim Hunt

Estimated:

Not Specified

Remaining:

Logged:

5h 15m