Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-69453

Form field icons

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 3.8.4, 3.9.1, 3.10
    • 3.9.4
    • Themes
    • MOODLE_310_STABLE, MOODLE_38_STABLE, MOODLE_39_STABLE
    • MOODLE_39_STABLE
    • MDL-69453-master
    • Hide

      Please test in themes Boost and Classic.

      Test normal, required fields, fields with help

      1. Install the attached file formstest.php in your Moodle root
      2. Navigate to the formstest.php page
      3. Click the "Show with both" link in the alert box
        #Verify the required icon and help icon are aligned
      4. Change your browser size to small (max 525px wide)
      5. Verify the required icon and the help icon are aligned and displayed right after the form label
      Show
      Please test in themes Boost and Classic. Test normal, required fields, fields with help Install the attached file formstest.php in your Moodle root Navigate to the formstest.php page Click the "Show with both" link in the alert box # Verify the required icon and help icon are aligned Change your browser size to small (max 525px wide) Verify the required icon and the help icon are aligned and displayed right after the form label

    Description

      The alignment of icons on form fields is a bit off. When the help and required icons are shown they are not aligned very well.

      The advanced icon does not really mean anything since the show advanced feature has been removed in MDL-30640.

      When hovering over the required icon a question mark is shown which is a bit weird.

      The current form field icons for Moodle forms are:

      Meaning icon
      Required
      Advanced
      Help

      Attachments

        1. with patch.png
          with patch.png
          267 kB
        2. without patch.png
          without patch.png
          245 kB
        3. test-1.png
          test-1.png
          17 kB
        4. required form fields.png
          required form fields.png
          60 kB
        5. image-2020-11-01-11-56-39-986.png
          image-2020-11-01-11-56-39-986.png
          314 kB
        6. image-2020-10-31-13-07-25-582.png
          image-2020-10-31-13-07-25-582.png
          83 kB
        7. iconrequired.png
          iconrequired.png
          2 kB
        8. iconhelp.png
          iconhelp.png
          2 kB
        9. iconadvanced.png
          iconadvanced.png
          2 kB
        10. formstest.php
          11 kB
        11. advanced form fields.png
          advanced form fields.png
          105 kB

        Issue Links

          has a non-specific relationship to

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDLSITE-6400 Coding style/backwards compatibility: We need a rule to stop unnecessary HTML changes on stable branches which break themes

          • Low - Cosmetic problems, nice-to-have features
          • Open
          is child of

          Sub-task - Issues are sometimes broken into multiple sub-tasks. MDL-30640 Remove 'Advanced field' form functionality

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Activity

            People

              basbrands Bas Brands
              basbrands Bas Brands
              Luca Bösch Luca Bösch
              Adrian Greeve Adrian Greeve
              Shamim Rezaie Shamim Rezaie
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                18/Jan/21

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 5 hours, 15 minutes
                  5h 15m