[MDL-69460] Check for removed files before CLI upgrade - Moodle Tracker

XML

Word

Printable

Details

Type: Improvement
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.8.4, 3.9.1
Fix Version/s: 3.11
Component/s: Installation
Labels:
- ci
- release_notes
- triaged

Affected Branches:
MOODLE_38_STABLE, MOODLE_39_STABLE
Fixed Branches:
MOODLE_311_STABLE
Pull from Repository:
https://github.com/paulholden/moodle.git
Pull 3.11 Branch:
~~MDL-69460~~-311
Pull 3.11 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_311_STABLE...paulholden:MDL-69460-311
Pull Master Branch:
~~MDL-69460~~
Pull Master Diff URL:
https://github.com/moodle/moodle/compare/master...paulholden:MDL-69460
Testing Instructions:
Hide

Create/check out a 3.10.x site. For example:

$ git checkout MOODLE_310_STABLE

Install the 3.10 site

Check out the the branch for the instance that you're testing. e.g. for 311

$ git checkout MOODLE_311_STABLE

Create any of the following files that are being detected by the patch:

$ touch lib/coursecatlib.php

Run the CLI upgrade script:

$ sudo -u www-data php admin/cli/upgrade.php

Confirm that an error ("Mixed Moodle versions detected....") is displayed saying that there are problems upgrading, describing the correct procedure for upgrading to a major release

Delete the created file from step 4

Re-run the CLI upgrade script

Confirm that the upgrade proceeds
Show
Create/check out a 3.10.x site. For example: $ git checkout MOODLE_310_STABLE Install the 3.10 site Check out the the branch for the instance that you're testing. e.g. for 311 $ git checkout MOODLE_311_STABLE Create any of the following files that are being detected by the patch: $ touch lib/coursecatlib.php Run the CLI upgrade script: $ sudo -u www-data php admin/cli/upgrade.php Confirm that an error ("Mixed Moodle versions detected....") is displayed saying that there are problems upgrading, describing the correct procedure for upgrading to a major release Delete the created file from step 4 Re-run the CLI upgrade script Confirm that the upgrade proceeds

Description

When upgrading via the web interface, if the source code directory contains files from previous versions you get the error "Mixed Moodle versions detected, upgrade cannot continue" (~~MDL-30929~~).

When upgrading using admin/cli/upgrade.php this check does not occur and the upgrade proceeds.

I suggest that the CLI script should also perform this check, exiting with an error if it fails. I think there are third party web platform managers (e.g. Softaculous) which are overwriting existing Moodle directories with later versions then running the CLI script. This apparently completes successfully but can result in a non-working site. E.g. upgrade Moodle 3.4 to 3.9 (via 3.5) overwriting the files there's a JavaScript exception:

TypeError: Cannot call a class as a function

This breaks navigation, e.g. the site administration page's tabs don't work.

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

MDL-69460_Test Passed.png
381 kB
22/Apr/21 1:01 PM

Issue Links

duplicates

MDL-53596 Make CLI upgrade to verify upgrade_stale_php_files_present()

Closed

has a non-specific relationship to

MDL-30929 detect incorrect major version upgrades by looking for files that are supposed to be removed

Closed

Activity

People

Assignee:: Paul Holden

Reporter:: Leon Stringer

Peer reviewer:: Eloy Lafuente (stronk7)

Integrator:: Andrew Lyons

Tester:: Gladys Basiana

Participants:: Andrew Lyons, CiBoT, Eloy Lafuente (stronk7), Gladys Basiana, Leon Stringer, Paul Holden

Component watchers:: Matteo Scaramuccia, David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo

Votes:: 2 Vote for this issue

Watchers:: 5 Start watching this issue

Dates

Created:: 12/Aug/20 8:13 PM

Updated:: 07/May/21 6:01 PM

Resolved:: 23/Apr/21 6:39 PM

Fix Release Date:: 17/May/21

Time Tracking

Estimated:

Not Specified

Remaining:

Logged:

2h 25m