[MDL-69477] PHP Notice: Undefined property: stdClass::$searchenginequeryonly - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Critical
Resolution: Fixed
Affects Version/s: 3.10, 4.0
Fix Version/s: 3.10
Component/s: Global search, Installation
Labels:
- ci
- triaged

Affected Branches:
MOODLE_310_STABLE, MOODLE_400_STABLE
Fixed Branches:
MOODLE_310_STABLE
Pull from Repository:
https://github.com/stronk7/moodle.git
Pull Master Branch:
~~MDL-69477~~
Pull Master Diff URL:
https://github.com/stronk7/moodle/compare/MDL-69477~1...MDL-69477
Testing Instructions:
Hide

Ensure that you have, debugging set to developer level and debugging display enabled. Can be done by setting, in the config.php file, these:

$CFG->debug = E_ALL | E_STRICT;

$CFG->debugdisplay = true;

Init phpunit (php admin/tool/phpunit/cli/init.php)

Verify that there is NOT any "PHP Notice" (like the one in the description of the issue) after the "-->System" line of the output.

Init behat (php admin/tool/behat/cli/init.php)

Verify that there is NOT any "PHP Notice" (like the one in the description of the issue) after the "-->System" line of the output.

Install moodle, via CLI or via Web (one of them is enough)

If using CLI verify that there is NOT any "PHP Notice" (like the one in the description of the issue) after the "-->System" line of the output.

If using Web verify that there is NOT any "PHP Notice" (like the one in the description of the issue) in the web server error logs (when the tables are being created, there can be other notices in other install pages).
Show
Ensure that you have, debugging set to developer level and debugging display enabled. Can be done by setting, in the config.php file, these: $CFG->debug = E_ALL | E_STRICT; $CFG->debugdisplay = true; Init phpunit ( php admin/tool/phpunit/cli/init.php ) Verify that there is NOT any "PHP Notice" (like the one in the description of the issue) after the "-->System" line of the output. Init behat ( php admin/tool/behat/cli/init.php ) Verify that there is NOT any "PHP Notice" (like the one in the description of the issue) after the "-->System" line of the output. Install moodle, via CLI or via Web (one of them is enough) If using CLI verify that there is NOT any "PHP Notice" (like the one in the description of the issue) after the "-->System" line of the output. If using Web verify that there is NOT any "PHP Notice" (like the one in the description of the issue) in the web server error logs (when the tables are being created, there can be other notices in other install pages).

Description

This is a regression of ~~MDL-68729~~, where a PHP Notice is happening on install / phpunit & behat init:

PHP Notice:  Undefined property: stdClass::$searchenginequeryonly in /Users/stronk7/git_moodle/moodle/admin/settings/plugins.php on line 558

Notice: Undefined property: stdClass::$searchenginequeryonly in /Users/stronk7/git_moodle/moodle/admin/settings/plugins.php on line 558

It's specially harmful because I detected it when local_codechecker scheduled integration suddenly stopped working:

...

 7/9 [=====================>------]  77% 41 secs [Initialize test suite]

288  [MoodlePluginCI\Process\MoodlePhpException]

289  PHP error message was detected when running this command:

290    php -d log_errors=1 -d error_log=NULL /home/travis/build/moodle/admin/too

291  l/behat/cli/util_single_run.php --install

292  Moodle scripts should run without any PHP errors.

293  Error Output

294  ============

295  PHP Notice:  Undefined property: stdClass::$searchenginequeryonly in /home/

296  travis/build/moodle/admin/settings/plugins.php on line 558

...

it seems that we'll need to protect that with the usual empty() checks... on it...

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

MDL-69477.png
142 kB
19/Aug/20 3:10 PM

Issue Links

is a regression caused by

MDL-68729 Search: Allow query on one Solr server and indexing on another

Closed

Activity

People

Assignee:: Eloy Lafuente (stronk7)

Reporter:: Eloy Lafuente (stronk7)

Peer reviewer:: Carlos Escobedo

Integrator:: Víctor Déniz Falcón

Tester:: Anna Carissa Sadia

Participants:: Anna Carissa Sadia, Carlos Escobedo, CiBoT, Eloy Lafuente (stronk7), Víctor Déniz Falcón

Component watchers:: Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Laurent David, Sara Arjona (@sarjona), Matteo Scaramuccia, Andrew Lyons, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze

Votes:: 3 Vote for this issue

Watchers:: 7 Start watching this issue

Dates

Created:: 14/Aug/20 11:28 PM

Updated:: 22/Aug/20 3:10 AM

Resolved:: 22/Aug/20 3:10 AM

Fix Release Date:: 9/Nov/20

Time Tracking

Estimated:

Remaining:

Logged:

4h 15m