Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 3.7.7, 3.8.4, 3.9.1, 3.10, 4.0
-
Component/s: Themes
-
Testing Instructions:
-
Workaround:
-
Affected Branches:MOODLE_310_STABLE, MOODLE_37_STABLE, MOODLE_38_STABLE, MOODLE_39_STABLE, MOODLE_400_STABLE
-
Fixed Branches:MOODLE_38_STABLE, MOODLE_39_STABLE
-
Pull from Repository:
-
Pull 3.8 Branch:wip_
MDL-69491_m38 -
Pull 3.9 Branch:wip_
MDL-69491_m39 -
Pull 3.10 Branch:wip_
MDL-69491_m310 -
Pull Master Branch:wip_
MDL-69491_master -
Pull Master Diff URL:
Description
In 'theme_boost_get_pre_scss' there is the code:
$scss .= '$font-size-base: ' . (1 / 100 * $theme->settings->fontsize) . "rem !default;\n";
which assumes that the 'fontsize' setting is in 'rem' units. However:
- If a theme declares a setting of the same name (in effect to override the setting) with a non-numeric value then the error 'A non well formed numeric value encountered' happens when 'Purge all caches'. This is because of the way that 'get_pre_scss_code' works in 'outputlib.php' and the child theme theme_config instance (referenced by $theme) is used with the Boost code 'theme_boost_get_pre_scss'.
- Boost has no 'fontsize' setting delaired in its 'settings.php'!
Therefore this code is redundant and I propose it should be removed = its a bug!
Code's been there since MDL-56511 with the string:
$string['fontsize_desc'] = 'Enter a fontsize in %';
stating percent and yet the code is 'rem'! Thus a bug in MDL-56511.