Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-69493

Cohort management icons return URL params incorrectly escaped

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.8.4, 3.9.1, 3.10, 4.0
    • Fix Version/s: 3.8.5, 3.9.2
    • Component/s: Cohorts
    • Labels:
    • Testing Instructions:
      Hide
      1. Navigate to Users > Accounts > Cohorts in site administration
      2. Click the Add new cohort tab
      3. Create a new cohort called "Foobar" and press Save changes
      4. Enter "Foobar" in the Search cohort field and press Search
      5. Under the Edit column press the Hide icon
      6. Confirm you are returned to the same page
      7. Under the Edit column press the Edit icon
      8. Confirm the URL contains "%26search" (instead of %26amp%3Bsearch)
      9. Update the Cohort ID field and press Save changes
      10. Confirm you are returned to the same page
      11. Under the Edit column press the Assign icon
      12. Add the admin user to the cohort and Back to cohorts
      13. Confirm you are returned to the same page
      14. Under the edit columns press the Delete icon
      15. Confirm the deletion
      16. Confirm you are returned to the same page

       
       

      Show
      Navigate to Users > Accounts > Cohorts in site administration Click the Add new cohort tab Create a new cohort called "Foobar" and press Save changes Enter "Foobar" in the Search cohort field and press Search Under the Edit column press the Hide icon Confirm you are returned to the same page Under the Edit column press the Edit icon Confirm the URL contains "%26search" (instead of %26amp%3Bsearch) Update the Cohort ID field and press Save changes Confirm you are returned to the same page Under the Edit column press the Assign icon Add the admin user to the cohort and Back to cohorts Confirm you are returned to the same page Under the edit columns press the Delete icon Confirm the deletion Confirm you are returned to the same page    
    • Affected Branches:
      MOODLE_310_STABLE, MOODLE_38_STABLE, MOODLE_39_STABLE, MOODLE_400_STABLE
    • Fixed Branches:
      MOODLE_38_STABLE, MOODLE_39_STABLE
    • Pull 3.8 Branch:
    • Pull 3.9 Branch:
    • Pull Master Branch:

      Description

      The action icon URLs used when managing cohorts contains a &returnurl= parameter whose own parameters are incorrectly escaped, producing URLs such as the following (note & are escaped as "&"):

      • <WWWROOT>/cohort/edit.php?id=4&returnurl=%2Fcohort%2Findex.php%3Fpage%3D0%26amp%3Bcontextid%3D1%26amp%3Bshowall%3D1&sesskey=1tk7ia4gln&hide=1

      Rather than:

      • <WWWROOT>/cohort/edit.php?id=4&returnurl=%2Fcohort%2Findex.php%3Fpage%3D0%26contextid%3D1%26showall%3D1&sesskey=1tk7ia4gln&hide=1

        Attachments

          Activity

            People

            Assignee:
            pholden Paul Holden
            Reporter:
            pholden Paul Holden
            Peer reviewer:
            Sara Arjona (@sarjona)
            Integrator:
            Eloy Lafuente (stronk7)
            Tester:
            Anna Carissa Sadia
            Participants:
            Component watchers:
            Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona)
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              14/Sep/20

                Time Tracking

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 hour, 50 minutes
                1h 50m