Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-69510

Use warning notification instead of plain text to highlight missing ldap module on settings pages

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.10, 4.0
    • Fix Version/s: 3.10
    • Component/s: Administration
    • Labels:
    • Testing Instructions:
      Hide

      With LDAP Disabled

      1. Disable ldap and restart the web server: 

        sudo phpdismod ldap
        		 
        sudo service apache2 restart

      2. Now, visit Site admin > Plugins > Authentication > Manage authentication plugins
      3. Select 'Settings' next to ldap
      4. Verify you see a yellow warning notification at the top of the page telling you that ldap might be disabled.
      5. Verify the text is NOT italicised
      6. Verify you do not see the 'auth_ldap | host_url' setting on the page
      7. Go back to 'Manage authentication plugins'
      8. Click 'Settings' for the CAS Server plugin
      9. Verify you see a yellow warning notification at the top of the page telling you that ldap might be disabled.
      10. Verify the text is NOT italicised
      11. Verify you do not see the 'auth_cas | auth_name' setting on the page
      12. Now, visit Site admin > Plugins > Enrolment > Manage enrol plugins
      13. Select 'Settings' next to ldap
      14. Verify you see a yellow warning notification at the top of the page telling you that ldap might be disabled.
      15. Verify the text is NOT italicised
      16. Verify you do not see the 'enrol_ldap | host_url' setting on the page

      With LDAP Enabled

      1. Enable ldap and restart the web server: 

        sudo phpenmod ldap
        		 
        sudo service apache2 restart

      2. Now, visit Site admin > Plugins > Authentication > Manage authentication plugins
      3. Select 'Settings' next to ldap
      4. Verify you DO NOT see a yellow warning
      5. Verify you DO see the 'auth_ldap | host_url' setting on the page
      6. Go back to 'Manage authentication plugins'
      7. Click 'Settings' for the CAS Server plugin
      8. Verify you DO NOT see a yellow warning notification
      9. Verify you DO see the 'auth_cas | auth_name' setting on the page
      10. Now, visit Site admin > Plugins > Enrolment > Manage enrol plugins
      11. Select 'Settings' next to ldap
      12. Verify you DO NOT see a yellow warning notification
      13. Verify you DO see the 'enrol_ldap | host_url' setting on the page
      Show
      With LDAP Disabled Disable ldap and restart the web server: sudo phpdismod ldap sudo service apache2 restart Now, visit Site admin > Plugins > Authentication > Manage authentication plugins Select 'Settings' next to ldap Verify you see a yellow warning notification at the top of the page telling you that ldap might be disabled. Verify the text is NOT italicised Verify you do not see the 'auth_ldap | host_url' setting on the page Go back to 'Manage authentication plugins' Click 'Settings' for the CAS Server plugin Verify you see a yellow warning notification at the top of the page telling you that ldap might be disabled. Verify the text is NOT italicised Verify you do not see the 'auth_cas | auth_name' setting on the page Now, visit Site admin > Plugins > Enrolment > Manage enrol plugins Select 'Settings' next to ldap Verify you see a yellow warning notification at the top of the page telling you that ldap might be disabled. Verify the text is NOT italicised Verify you do not see the 'enrol_ldap | host_url' setting on the page With LDAP Enabled Enable ldap and restart the web server: sudo phpenmod ldap sudo service apache2 restart Now, visit Site admin > Plugins > Authentication > Manage authentication plugins Select 'Settings' next to ldap Verify you DO NOT see a yellow warning Verify you DO see the 'auth_ldap | host_url' setting on the page Go back to 'Manage authentication plugins' Click 'Settings' for the CAS Server plugin Verify you DO NOT see a yellow warning notification Verify you DO see the 'auth_cas | auth_name' setting on the page Now, visit Site admin > Plugins > Enrolment > Manage enrol plugins Select 'Settings' next to ldap Verify you DO NOT see a yellow warning notification Verify you DO see the 'enrol_ldap | host_url' setting on the page
    • Affected Branches:
      MOODLE_310_STABLE, MOODLE_400_STABLE
    • Fixed Branches:
      MOODLE_310_STABLE
    • Pull from Repository:
    • Pull 3.8 Branch:
    • Pull 3.8 Diff URL:
    • Pull 3.9 Branch:
    • Pull 3.9 Diff URL:
    • Pull 3.10 Branch:
      MDL-69510-310
    • Pull 3.10 Diff URL:
    • Pull Master Branch:
      MDL-69510-master
    • Pull Master Diff URL:

      Description

      In both enrol/ldap/settings.php and auth/ldap/settings.php, if php-ldap isn't enabled, a string is displayed on the settings page, and a number of settings are not rendered.

      The text doesn't stand out to the user, so we should consider using a notification (of type warning) like we do in other settings pages like enrol/lti/settings.

        Attachments

          Issue Links

          Testing discovered

          Improvement - An enhancement to an existing Moodle feature. MDL-69651 Small changes to auth/enrol admin settings when requirements are not fullfilled

          • Minor - Minor loss of function where workaround is possible
          • Open

            Activity

              People

              Assignee:
              jaked Jake Dallimore
              Reporter:
              jaked Jake Dallimore
              Peer reviewer:
              Mihail Geshoski
              Integrator:
              Eloy Lafuente (stronk7)
              Tester:
              Gladys Basiana
              Participants:
              Component watchers:
              Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                9/Nov/20

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 hour, 35 minutes
                  1h 35m