Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-69521

PRE: Change all comments in code pointing to 4.0, to 3.10

    XMLWordPrintable

    Details

    • Type: Task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.10, 4.0
    • Fix Version/s: 3.10
    • Component/s: General
    • Labels:
    • Testing Instructions:
      Hide

      NOTE: Testing to be performed by a developer (or the very same integrator).

      As far as this issue are just changes in comments:

      1) Verify that all the changes make sense.
      2) Verify that all the remaining cases shared as comments in the issue (one after each commit) are really false positives that don't need to be modified.

      Cannot imagine much else to test, while performing the changes I've visited the issues being mentioned (deprecation epics and issues within them) checking that the correct versions were mentioned in descriptions.

      So just the 1 & 2 above should be enough. Feel free to search for other cases, I cannot imagine any other.

      Ciao

      Show
      NOTE: Testing to be performed by a developer (or the very same integrator). As far as this issue are just changes in comments: 1) Verify that all the changes make sense. 2) Verify that all the remaining cases shared as comments in the issue (one after each commit) are really false positives that don't need to be modified. Cannot imagine much else to test, while performing the changes I've visited the issues being mentioned (deprecation epics and issues within them) checking that the correct versions were mentioned in descriptions. So just the 1 & 2 above should be enough. Feel free to search for other cases, I cannot imagine any other. Ciao
    • Affected Branches:
      MOODLE_310_STABLE, MOODLE_400_STABLE
    • Fixed Branches:
      MOODLE_310_STABLE
    • Pull 3.10 Branch:
      MDL-69521_310
    • Pull Master Branch:

      Description

      Any existing comment (deprecations mainly) in codebase pointing to 4.0 should be moved to 3.10.

      Similarly 4.1 => 3.11, 4.2 => 4.0 and 4.3 => 4.1

      This is really parallel with the very same change performed in the tracker where all the deprecation epics where rearranged that way.

      To be done in both MOODLE_310_STABLE and master. And in order to avoid any overlapping (one commit each and in strict order).

      1) 4.0 => 3.10
      2) 4.1 => 3.11
      3) 4.2 => 4.0
      4) 4.3 => 4.1
      5) 4.4 => 4.2
      6) 4.5 => 4.3 (there isn't any)

      The regular expression used to find occurrences, ignoring some false positives (not all), replace "X" by the desired version, is:

      ag '\b(todo|mdl|deprecate|remove|moodle).*\b4\.X' --ignore={\
      '*.map','*.json','*.ser','build','jquery',\
      'install/lang','lib/adodb','mongodb/MongoDB',\
      'horde/framework','joubel/editor','chartjs-lazy.js',\
      'tiny_mce.js','axe.min.js'}
      

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              stronk7 Eloy Lafuente (stronk7)
              Reporter:
              stronk7 Eloy Lafuente (stronk7)
              Peer reviewer:
              Mathew May
              Integrator:
              Sara Arjona (@sarjona)
              Tester:
              Sara Arjona (@sarjona)
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                9/Nov/20

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 4 hours, 45 minutes
                  4h 45m