[MDL-69586] User tour privacy export can include preferences for wrong user - Moodle Tracker

XML

Word

Printable

Affected Branches:
MOODLE_310_STABLE, MOODLE_38_STABLE, MOODLE_39_STABLE, MOODLE_400_STABLE
Fixed Branches:
MOODLE_38_STABLE, MOODLE_39_STABLE
Pull from Repository:
https://github.com/paulholden/moodle.git
Pull 3.9 Branch:
~~MDL-69586~~-39
Pull 3.9 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_39_STABLE...paulholden:MDL-69586-39
Pull Master Branch:
~~MDL-69586~~
Pull Master Diff URL:
https://github.com/moodle/moodle/compare/master...paulholden:MDL-69586
Testing Instructions:
Hide

Run testcase:

$ vendor/bin/phpunit tool_usertours_privacy_provider_testcase
Show
Run testcase: $ vendor/bin/phpunit tool_usertours_privacy_provider_testcase

The export_user_preferences privacy method doesn't pass the $userid parameter onto get_user_preferences so it defaults to the current user

Found while looking at ~~MDL-69014~~

has a non-specific relationship to

MDL-70763 Preferences for wrong user can be used in privacy export

has been marked as being related by

MDL-69014 User preferences not removed when tours are deleted

Participants:: CiBoT, Eloy Lafuente (stronk7), Mihail Geshoski, Paul Holden, Sara Arjona (@sarjona)

Component watchers:: Andrew Lyons, Adrian Greeve, David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo, David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo

Estimated:

Not Specified

Remaining:

Logged:

1h 11m