Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-69607

Remove can_delete call from delete in Comments API

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 3.8.4, 3.9.1
    • Fix Version/s: None
    • Component/s: Comments
    • Labels:
    • Affected Branches:
      MOODLE_38_STABLE, MOODLE_39_STABLE

      Description

      While integrating MDL-64525, the following issue has been raised. Methods can_delete and delete in comment/lib.php should be reviewed because:

      • can_delete should only perform all the checks
      • delete should perform the removal unconditionally

       

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              Unassigned Unassigned
              Reporter:
              sarjona Sara Arjona (@sarjona)
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated: