Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-69607

Remove can_delete call from delete in Comments API

    XMLWordPrintable

Details

    • Improvement
    • Status: Open
    • Minor
    • Resolution: Unresolved
    • 3.8.4, 3.9.1
    • None
    • Comments
    • MOODLE_38_STABLE, MOODLE_39_STABLE

    Description

      While integrating MDL-64525, the following issue has been raised. Methods can_delete and delete in comment/lib.php should be reviewed because:

      • can_delete should only perform all the checks
      • delete should perform the removal unconditionally

       

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              sarjona Sara Arjona (@sarjona)
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Laurent David, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated: