Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-69632

Fix the legacy coding style in the admin/settings/server.php file

    XMLWordPrintable

    Details

    • Type: Task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.9.1
    • Fix Version/s: 3.10
    • Component/s: Administration
    • Labels:
    • Testing Instructions:
      Hide

      Testing requirements

      • Ability to run CLI scripts
      • Ability to confirm that two files are identical

      Anti-regression test

      1. Put the attached dumpadminroot.php to the root of the recent unpatched Moodle.
      2. Run

      php dumpadminroot.php > before.txt
      

      to save the structure of the admin tree before the patch.
      3. Change over to the patched version of Moodle with this issue present and have the same dumpadminroot.php file there, too.
      4. Run

      php dumpadminroot.php > after.txt
      

      to save the structure of the admin tree before the patch.
      5. TEST Make sure (using a utility such as diff or similar that the before.txt and after.txt files are identical.

      Show
      Testing requirements Ability to run CLI scripts Ability to confirm that two files are identical Anti-regression test 1. Put the attached dumpadminroot.php to the root of the recent unpatched Moodle. 2. Run php dumpadminroot.php > before.txt to save the structure of the admin tree before the patch. 3. Change over to the patched version of Moodle with this issue present and have the same dumpadminroot.php file there, too. 4. Run php dumpadminroot.php > after.txt to save the structure of the admin tree before the patch. 5. TEST Make sure (using a utility such as diff or similar that the before.txt and after.txt files are identical.
    • Affected Branches:
      MOODLE_39_STABLE
    • Fixed Branches:
      MOODLE_310_STABLE
    • Pull from Repository:
    • Pull 3.10 Branch:
      MDL-69632-310-adminserversettings
    • Pull Master Branch:
      MDL-69632-master-adminserversettings

      Description

      While working on MDL-67748 I started with fixing the ancient coding style in the file admin/settings/server.php so that I could start performing more changes there in a clean way.

      It turned out it would be easier to get this coding style fix integrated first so that we can focus on the actual changes in the follow up commits.

      The patch should only fix the coding style, with no other functional or visual change to the settings.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              mudrd8mz David Mudrák (@mudrd8mz)
              Reporter:
              mudrd8mz David Mudrák (@mudrd8mz)
              Peer reviewer:
              Luca Bösch
              Integrator:
              Sara Arjona (@sarjona)
              Tester:
              Janelle Barcega
              Participants:
              Component watchers:
              Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              1 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                9/Nov/20

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 3 hours, 30 minutes
                  3h 30m