[MDL-69637] Moving a section with drag an drop adds unnecessary aria labels - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.9.1, 3.10, 3.11.7, 4.0
Fix Version/s: 3.11.8
Component/s: Accessibility, Course
Labels:

Affected Branches:
MOODLE_310_STABLE, MOODLE_311_STABLE, MOODLE_39_STABLE, MOODLE_400_STABLE
Fixed Branches:
MOODLE_311_STABLE
Pull from Repository:
https://github.com/james-cnz/moodle
Pull 3.11 Branch:
mdl-69637_311
Pull 3.11 Diff URL:
https://github.com/james-cnz/moodle/compare/mdl-69637_311~1...mdl-69637_311
Testing Instructions:
Hide

Create a new Topics format course with at least two sections.

Turn editing on.

Inspect the HTML for Topic 1.

Verify the li element with id "section-1" does have an attribute "aria-labelledby"

Verify the li element with id "section-1" has no attribute "aria-label".

Drag and drop Topic 1 after Topic 2.

Inspect the HTML for the new Topic 1.

Verify the li element with id "section-1" still does have an attribute "aria-labelledby"

Verify the li element with id "section-1" still has no attribute "aria-label". [This will fail before the patch.]

Set Course settings > Course format > Format to "Weekly format", and save.

Inspect the HTML for the first week.

Verify the li element with id "section-1" does have an attribute "aria-labelledby"

Verify the li element with id "section-1" has no attribute "aria-label".

Drag and drop the first week after the second week.

Inspect the HTML for the new first week.
Verify the li element with id "section-1" still does have an attribute "aria-labelledby"
Verify the li element with id "section-1" still has no attribute "aria-label". [This will fail before the patch.]
Show
Create a new Topics format course with at least two sections. Turn editing on. Inspect the HTML for Topic 1. Verify the li element with id "section-1" does have an attribute "aria-labelledby" Verify the li element with id "section-1" has no attribute "aria-label". Drag and drop Topic 1 after Topic 2. Inspect the HTML for the new Topic 1. Verify the li element with id "section-1" still does have an attribute "aria-labelledby" Verify the li element with id "section-1" still has no attribute "aria-label". [This will fail before the patch.] Set Course settings > Course format > Format to "Weekly format", and save. Inspect the HTML for the first week. Verify the li element with id "section-1" does have an attribute "aria-labelledby" Verify the li element with id "section-1" has no attribute "aria-label". Drag and drop the first week after the second week. Inspect the HTML for the new first week. Verify the li element with id "section-1" still does have an attribute "aria-labelledby" Verify the li element with id "section-1" still has no attribute "aria-label". [This will fail before the patch.]

Description

FULL STEPS

In Moodle 3.9 or later, in topics or weekly format, with editing on, use web browser's HTML inspector on a section, noting that no aria-label property is present. (These were removed in favour of aria-labelledby.) Drag and drop the section to move it. Using web browser's HTML inspector again, note that an aria-label property has been added.

THE FIX

In course/format/topics/format.js (and the weeks format) function process_sections() remove the update to aria-label.

THE CAUSE
With ~~MDL-68189~~, in course/format/renderer.php function section_header() the use of aria-label was replaced with aria-labelledby, but the update to aria-label was not removed.

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

MDL-69637 testing.webm
1.89 MB
09/Jun/22 11:28 AM

Issue Links

has been marked as being related by

MDL-68189 Names of sections renamed inline do not change in the keyboard drag and drop menu

Closed

Activity

People

Assignee:: James E. Calder

Reporter:: James E. Calder

Peer reviewer:: Ferran Recio

Integrator:: Jun Pataleta

Tester:: Angelia Dela Cruz

Participants:: Amaia Anabitarte, Angelia Dela Cruz, Anna Carissa Sadia, CiBoT, Eloy Lafuente (stronk7), Ferran Recio, James E. Calder, Jun Pataleta

Component watchers:: Amaia Anabitarte, Carlos Escobedo, Laurent David, Sabina Abellan, Sara Arjona (@sarjona)

Votes:: 0 Vote for this issue

Watchers:: 7 Start watching this issue

Dates

Created:: 05/Sep/20 7:21 PM

Updated:: 13/Jun/22 11:45 PM

Resolved:: 10/Jun/22 11:48 PM

Fix Release Date:: 11/Jul/22

Time Tracking

Estimated:

Remaining:

Logged:

1h 19m