Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-69638

Update upgrade_stale_php_files_present() before 3.10 release

    XMLWordPrintable

    Details

    • Type: Task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.10, 4.0
    • Fix Version/s: 3.10
    • Component/s: Installation
    • Labels:
    • Affected Branches:
      MOODLE_310_STABLE, MOODLE_400_STABLE
    • Fixed Branches:
      MOODLE_310_STABLE
    • Pull from Repository:
    • Pull 3.10 Branch:
      MDL-69638_310
    • Pull 3.10 Diff URL:
    • Pull Master Branch:
    • Pull Master Diff URL:
    • Testing Instructions:
      Hide

      Note: TARGET for this issue are:

      1. MOODLE_310_STABLE
      2. master

      (meaning testing must be done twice, once for each TARGET)

      web

      1. Create/check out a 3.9.x site. For example: 

        git checkout v3.9.0

      2. Install the 3.9 site.
      3. Check out the TARGET branch 

        git checkout TARGET

      4. Create any of the following files that are being detected by the patch. (e.g. on Linux, use the "touch" command):
        • grade/grading/classes/privacy/gradingform_provider.php 

          touch grade/grading/classes/privacy/gradingform_provider.php

        • lib/coursecatlib.php 

          touch lib/coursecatlib.php

        • ...
      5. Open your Moodle instance on your browser.
      6. Log in as admin and proceed with the upgrade.
      7. Verify that a notice ("Mixed Moodle versions detected....") is displayed saying that there are problems upgrading and a proper procedure for upgrading to a major release.
      8. Delete the touched file(s) in point 4.
      9. Click "Reload".
      10. Verify that the upgrade now proceeds ok.

      cli

      1. Disclaimer: CLI upgrade does not run the upgrade_stale_php_files_present() check. MDL-53596 has been created about that. Nothing to test here yet.
      Show
      Note: TARGET for this issue are: MOODLE_310_STABLE master (meaning testing must be done twice, once for each TARGET) web Create/check out a 3.9.x site. For example: git checkout v3.9.0 Install the 3.9 site. Check out the TARGET branch git checkout TARGET Create any of the following files that are being detected by the patch. (e.g. on Linux, use the " touch " command): grade/grading/classes/privacy/gradingform_provider.php touch grade/grading/classes/privacy/gradingform_provider.php lib/coursecatlib.php touch lib/coursecatlib.php ... Open your Moodle instance on your browser. Log in as admin and proceed with the upgrade. Verify that a notice ("Mixed Moodle versions detected....") is displayed saying that there are problems upgrading and a proper procedure for upgrading to a major release. Delete the touched file(s) in point 4. Click " Reload ". Verify that the upgrade now proceeds ok. cli Disclaimer: CLI upgrade does not run the upgrade_stale_php_files_present() check. MDL-53596 has been created about that. Nothing to test here yet.

      Description

      Simply verify we have a number (4-5) of files for the next major release. They all must be files deleted since last stable version and current master (310_STABLE this time, we are under parallel development period).

      git diff --name-status MOODLE_XX_STABLE..master | grep ^D

      Note that it's better not to pick any plugin file that maybe reinstalled manually (exception being forum files because that plugin is mandatory).

        Attachments

          Issue Links

          has a clone

          Task - A task that needs to be completed. Tasks usually refer to work that must be done outside the product. MDL-71149 Update upgrade_stale_php_files_present() before 3.11 release

          • Minor - Minor loss of function where workaround is possible
          • Closed
          has a non-specific relationship to

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-53596 Make CLI upgrade to verify upgrade_stale_php_files_present()

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Task - A task that needs to be completed. Tasks usually refer to work that must be done outside the product. MDL-68165 Update upgrade_stale_php_files_present() before 3.9 release

          • Minor - Minor loss of function where workaround is possible
          • Closed

            Activity

              People

              Assignee:
              stronk7 Eloy Lafuente (stronk7)
              Reporter:
              stronk7 Eloy Lafuente (stronk7)
              Peer reviewer:
              Nobody Nobody
              Integrator:
              Sara Arjona (@sarjona) Sara Arjona (@sarjona)
              Tester:
              Anna Carissa Sadia Anna Carissa Sadia
              Participants:
              Component watchers:
              Matteo Scaramuccia, Andrew Lyons, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                9/Nov/20

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 hour, 51 minutes
                  1h 51m