Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-69695

Force download undefined notice when displaying folders inline

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • 3.10
    • 3.10
    • Resource
    • MOODLE_310_STABLE
    • MOODLE_310_STABLE
    • Hide
      1. Login as admin
      2. Create a new course
      3. Visit new course and turn editing on
      4. Add a new Folder activity
      5. Upload any file to the Files element
      6. Set Display folder contents: Inline on a course page
      7. Set Force download of files
      8. Press Save and return to course
      9. Confirm there is no PHP notice about "undefined property"
      10. Hover over the file in the folder tree on the course page, confirm it has ?forcedownload=1 appended to the URL
      Show
      Login as admin Create a new course Visit new course and turn editing on Add a new Folder activity Upload any file to the Files element Set Display folder contents: Inline on a course page Set Force download of files Press Save and return to course Confirm there is no PHP notice about "undefined property" Hover over the file in the folder tree on the course page, confirm it has ?forcedownload=1 appended to the URL

      From MDL-28501

      When folders are set to display folder contents inline on a course page, the following notice is displayed on the course page:

      Notice:  Undefined property: stdClass::$forcedownload in /opt/moodle/master/src/mod/folder/renderer.php on line 150
      

            pholden Paul Holden
            pholden Paul Holden
            Peter Dias Peter Dias
            Sara Arjona (@sarjona) Sara Arjona (@sarjona)
            Janelle Barcega Janelle Barcega
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 hour, 40 minutes
                1h 40m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.