Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-69695

Force download undefined notice when displaying folders inline

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.10
    • Fix Version/s: 3.10
    • Component/s: Resource
    • Labels:
    • Testing Instructions:
      Hide
      1. Login as admin
      2. Create a new course
      3. Visit new course and turn editing on
      4. Add a new Folder activity
      5. Upload any file to the Files element
      6. Set Display folder contents: Inline on a course page
      7. Set Force download of files
      8. Press Save and return to course
      9. Confirm there is no PHP notice about "undefined property"
      10. Hover over the file in the folder tree on the course page, confirm it has ?forcedownload=1 appended to the URL
      Show
      Login as admin Create a new course Visit new course and turn editing on Add a new Folder activity Upload any file to the Files element Set Display folder contents: Inline on a course page Set Force download of files Press Save and return to course Confirm there is no PHP notice about "undefined property" Hover over the file in the folder tree on the course page, confirm it has ?forcedownload=1 appended to the URL
    • Affected Branches:
      MOODLE_310_STABLE
    • Fixed Branches:
      MOODLE_310_STABLE
    • Pull 3.10 Branch:
      MDL-69695-310
    • Pull Master Branch:

      Description

      From MDL-28501

      When folders are set to display folder contents inline on a course page, the following notice is displayed on the course page:

      Notice:  Undefined property: stdClass::$forcedownload in /opt/moodle/master/src/mod/folder/renderer.php on line 150
      

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              pholden Paul Holden
              Reporter:
              pholden Paul Holden
              Peer reviewer:
              Peter Dias
              Integrator:
              Sara Arjona (@sarjona)
              Tester:
              Janelle Barcega
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                9/Nov/20

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 hour, 40 minutes
                  1h 40m