Loading...

XML

Word

Printable

Affected Branches:
MOODLE_310_STABLE
Fixed Branches:
MOODLE_310_STABLE
Pull from Repository:
https://github.com/paulholden/moodle.git
Pull Main Branch:
~~MDL-69695~~
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/master...paulholden:MDL-69695
Testing Instructions:
Hide

Login as admin

Create a new course

Visit new course and turn editing on

Add a new Folder activity

Upload any file to the Files element

Set Display folder contents: Inline on a course page

Set Force download of files

Press Save and return to course

Confirm there is no PHP notice about "undefined property"

Hover over the file in the folder tree on the course page, confirm it has ?forcedownload=1 appended to the URL
Show
Login as admin Create a new course Visit new course and turn editing on Add a new Folder activity Upload any file to the Files element Set Display folder contents: Inline on a course page Set Force download of files Press Save and return to course Confirm there is no PHP notice about "undefined property" Hover over the file in the folder tree on the course page, confirm it has ?forcedownload=1 appended to the URL

When folders are set to display folder contents inline on a course page, the following notice is displayed on the course page:

Notice:  Undefined property: stdClass::$forcedownload in /opt/moodle/master/src/mod/folder/renderer.php on line 150

is a regression caused by

MDL-28501 For folder resource, allow files to be opened in the browser rather than being downloaded

Participants:: CiBoT, Janelle Barcega, Paul Holden, Peter Dias, Sara Arjona (@sarjona)

Estimated:

Remaining:

Logged:

1h 40m