Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-69696

Assign - Class refactoring

    XMLWordPrintable

Details

    • MOODLE_400_STABLE
    • MOODLE_400_STABLE
    • MDL-69696-master
    • Hide

      As most of the changes in this patch are structural and not related to functionality, broadly testing should cover the main assignment workflows. Creating, editing, completing, reviewing etc.

      A basic test case is (in all supported themes):

      • Create a Moodle course
      • Enrol at least one user in the teacher role
      • Enrol at least one user in the student role
      • Create a assignment activity with available from date in the past and the due date in the future. (other options can be set or left as default)
      • As an admin view the assignment
      • The main changes to look for (as an admin):
        • The submission status and grading summary  tables on the add submission page, now share the same styling. See: updated_view.png
      • As a student view the assignment
        • Table style should be consistent with:updated_view.png
      • As a teacher view the assignment
        • Table style should be consistent with:updated_view.png

       

      Show
      As most of the changes in this patch are structural and not related to functionality, broadly testing should cover the main assignment workflows. Creating, editing, completing, reviewing etc. A basic test case is (in all supported themes): Create a Moodle course Enrol at least one user in the teacher role Enrol at least one user in the student role Create a assignment activity with available from date in the past and the due date in the future. (other options can be set or left as default) As an admin view the assignment The main changes to look for (as an admin): The submission status and grading summary  tables on the add submission page, now share the same styling. See: updated_view.png As a student view the assignment Table style should be consistent with:updated_view.png As a teacher view the assignment Table style should be consistent with:updated_view.png  

    Description

      Mod assign is yet to be updated to the "new" PSR style for the majority of its output classes.

      This change moves the renderer class and splits out some classes from the omnibus renderable file.

      While not a complete refactoring these changes will make further enhancements to mod assign easier in the future. Most notably MDL-68913

      It also adds some minor visual changes to the assign summary screen to improve the display of the summary tables.

      Attachments

        1. MDL-69696_admin.png
          MDL-69696_admin.png
          108 kB
        2. MDL-69696_student.png
          MDL-69696_student.png
          103 kB
        3. MDL-69696_teacher.png
          MDL-69696_teacher.png
          108 kB
        4. updated_view.png
          updated_view.png
          91 kB

        Issue Links

          Activity

            People

              cameron1729 cameron1729
              mattp@catalyst-au.net Matt Porritt
              Andrew Madden Andrew Madden
              Adrian Greeve Adrian Greeve
              Angelia Dela Cruz Angelia Dela Cruz
              Adrian Greeve, Ilya Tregubov, Kevin Percy, Mathew May, Mihail Geshoski, Shamim Rezaie
              Votes:
              0 Vote for this issue
              Watchers:
              12 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                19/Apr/22

                Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 2 hours, 10 minutes
                  2h 10m