Loading...

XML

Word

Printable

Details

Type: Improvement
Resolution: Fixed
Priority: Minor
Fix Version/s: 4.0
Affects Version/s: 4.0
Component/s: Assignment
Labels:
- CatalystIT
- ci
- partner
- triaged

Affected Branches:
MOODLE_400_STABLE
Fixed Branches:
MOODLE_400_STABLE
Pull from Repository:
git://github.com/cameron1729/moodle.git
Pull Main Branch:
~~MDL-69696~~-master
Pull Main Diff URL:
https://github.com/cameron1729/moodle/compare/70073fdc74...MDL-69696-master
Testing Instructions:
Hide

As most of the changes in this patch are structural and not related to functionality, broadly testing should cover the main assignment workflows. Creating, editing, completing, reviewing etc.

A basic test case is (in all supported themes):

Create a Moodle course

Enrol at least one user in the teacher role

Enrol at least one user in the student role

Create a assignment activity with available from date in the past and the due date in the future. (other options can be set or left as default)

As an admin view the assignment

The main changes to look for (as an admin):

The submission status and grading summary tables on the add submission page, now share the same styling. See: updated_view.png

As a student view the assignment

Table style should be consistent with:updated_view.png

As a teacher view the assignment

Table style should be consistent with:updated_view.png
Show
As most of the changes in this patch are structural and not related to functionality, broadly testing should cover the main assignment workflows. Creating, editing, completing, reviewing etc. A basic test case is (in all supported themes): Create a Moodle course Enrol at least one user in the teacher role Enrol at least one user in the student role Create a assignment activity with available from date in the past and the due date in the future. (other options can be set or left as default) As an admin view the assignment The main changes to look for (as an admin): The submission status and grading summary tables on the add submission page, now share the same styling. See: updated_view.png As a student view the assignment Table style should be consistent with:updated_view.png As a teacher view the assignment Table style should be consistent with:updated_view.png

Description

Mod assign is yet to be updated to the "new" PSR style for the majority of its output classes.

This change moves the renderer class and splits out some classes from the omnibus renderable file.

While not a complete refactoring these changes will make further enhancements to mod assign easier in the future. Most notably ~~MDL-68913~~

It also adds some minor visual changes to the assign summary screen to improve the display of the summary tables.

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

MDL-69696_admin.png
108 kB
07/Oct/21 7:05 PM
MDL-69696_student.png
103 kB
07/Oct/21 7:05 PM
MDL-69696_teacher.png
108 kB
07/Oct/21 7:05 PM
updated_view.png
91 kB
15/Sep/20 1:32 PM

Issue Links

blocks

MDL-68913 Assign - Per attempt timing

Closed

will help resolve

MDL-68913 Assign - Per attempt timing

Closed

Activity

People

Assignee:: cameron1729

Reporter:: Matt Porritt

Peer reviewer:: Andrew Madden

Integrator:: Adrian Greeve

Tester:: Angelia Dela Cruz

Participants:: Adrian Greeve, Andrew Lyons, Andrew Madden, Angelia Dela Cruz, Brendan Heywood, cameron1729, CiBoT, Eloy Lafuente (stronk7), Matt Porritt, Misha Golenkov

Votes:: 0 Vote for this issue

Watchers:: 13 Start watching this issue

Dates

Created:: 15/Sep/20 11:08 AM

Updated:: 08/Oct/21 7:30 PM

Resolved:: 08/Oct/21 7:30 PM

Fix Release Date:: 19/Apr/22

Time Tracking

Estimated:

Remaining:

Logged:

2h 10m