Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-69698

List of licenses is not displayed in the user's preferred language

    XMLWordPrintable

Details

    • MOODLE_310_STABLE, MOODLE_39_STABLE, MOODLE_400_STABLE
    • MOODLE_39_STABLE
    • MDL-69698-39-licensecache
    • MDL-69698-master-licensecache
    • Hide
      1. Log in as the site admin.
      2. Go to Site administration > Language > Language packs.
      3. Install an additional language pack of your choice (any one that has at least some of the licenses translated will do).
      4. Select the newly installed language as the current language.
      5. Go to Site administration > Plugins > Caching > Configuration.
      6. Purge the "List of licences" cache.
      7. Go to Site administration > Licence > Licence manager.
      8. TEST The list of licenses should appear in your currently selected language.
      9. Switch the current language back to English.
      10. TEST The list of licenses should appear in English now.
      Show
      Log in as the site admin. Go to Site administration > Language > Language packs. Install an additional language pack of your choice (any one that has at least some of the licenses translated will do). Select the newly installed language as the current language. Go to Site administration > Plugins > Caching > Configuration. Purge the "List of licences" cache. Go to Site administration > Licence > Licence manager. TEST The list of licenses should appear in your currently selected language. Switch the current language back to English. TEST The list of licenses should appear in English now.

    Description

      This was originally reported as an MDLSITE issue affecting moodle.org:

      When uploading a new plugin version the 'Choose licence' language is not the language of the user.

      See:

      During the triage, it was confirmed and detected that this is actually an MDL core bug.

      In the license_manager::get_licenses() caching was introduced as a part of MDL-45184. The list of all licenses is being cached in MUC, including the localised full name of license. So depending on user's current language (the lucky one who initialised the cache rebuilt), the cache is populated in that language and then displayed as such to everybody.

      We must not cache the localised full names, only the short names.

      Attachments

        Issue Links

          Activity

            People

              mudrd8mz David Mudrák (@mudrd8mz)
              gb2048 Gareth J Barnard
              Victor Déniz Falcón Victor Déniz Falcón
              Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
              Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
              David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo, David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo, Huong Nguyen, Barbara Ramiro, Bas Brands, Mathew May, David Woloszyn, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                9/Nov/20

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 2 hours, 40 minutes
                  2h 40m