Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-69792

Deprecate unused backpack js functions

    XMLWordPrintable

    Details

    • Type: Task
    • Status: Waiting for integration review
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 3.9.2, 3.10.1
    • Fix Version/s: None
    • Component/s: Badges
    • Testing Instructions:
      Hide

      Requirements

      • 2 different Badgr.io US accounts
      • Outgoing server configured (mailcacher or similar)
      • ngrok or similar (for having a public URL in your Moodle instance).
      • Enable Moodle debugging (DEVELOPER MODE).

       Setup backpack

      1. In "Site administration / Badges / Manage backpacks", edit "https://badgr.io" backpack and:
        1. Enable "Include authentication details with the backpack".
        2. Set the Badge issuer email address and password with one of the Badgr accounts.

      Testing scenario 1: Create badges

      1. Login as admin.
      2. Go to "Site administration | Badges | Add a new badge" and create a badge at site level ("Badge 1").
      3. Check no deprecation warning is displayed.
      4. Add criteria to the badge so it can be manually issued by role.
      5. Go to "Site administration | Badges | Add a new badge" and create another badge at site level ("Badge 2").
      6. Add criteria to the badge so it can be manually issued by role.
      7. Enable both badges.
      8. Issue the badges to the admin user.
      9. Go to "Site administration | Badges | Manage badges".
      10. Check no deprecation warning is displayed.

      Testing scenario 2: List badges

      1. Go to "Dashboard / Preferences / Badges / Backpack settings"
      2. Connect to Badgr using account 2 (you'll need to check the email to verify the account).
      3. Check the state is set to "Connected" in the "Dashboard / Preferences / Badges / Backpack settings" page.
      4. Access to admin profile page.
      5. Check "Badge 1" and "Badge 2" are displayed in the "Badges" section.
      6. Access to "Badge 1".
      7. Check no deprecation warning is displayed.
      8. Check the "Add to backpack" button is displayed.
      9. Go to "Dashboard / Preferences / Badges / Manage badges".
      10. Check no deprecation warning is displayed.
      11. Check "Badge 1" and "Badge 2" are displayed and they have the "Add to backpack" icon.

       

      Show
      Requirements 2 different Badgr.io US accounts Outgoing server configured (mailcacher or similar) ngrok or similar (for having a public URL in your Moodle instance). Enable Moodle debugging (DEVELOPER MODE).  Setup backpack In "Site administration / Badges / Manage backpacks", edit "https://badgr.io" backpack and: Enable "Include authentication details with the backpack". Set the Badge issuer email address and password with one of the Badgr accounts. Testing scenario 1: Create badges Login as admin. Go to "Site administration | Badges | Add a new badge" and create a badge at site level ("Badge 1"). Check no deprecation warning is displayed. Add criteria to the badge so it can be manually issued by role. Go to "Site administration | Badges | Add a new badge" and create another badge at site level ("Badge 2"). Add criteria to the badge so it can be manually issued by role. Enable both badges. Issue the badges to the admin user. Go to "Site administration | Badges | Manage badges". Check no deprecation warning is displayed. Testing scenario 2: List badges Go to "Dashboard / Preferences / Badges / Backpack settings" Connect to Badgr using account 2 (you'll need to check the email to verify the account). Check the state is set to "Connected" in the "Dashboard / Preferences / Badges / Backpack settings" page. Access to admin profile page. Check "Badge 1" and "Badge 2" are displayed in the "Badges" section. Access to "Badge 1". Check no deprecation warning is displayed. Check the "Add to backpack" button is displayed. Go to "Dashboard / Preferences / Badges / Manage badges". Check no deprecation warning is displayed. Check "Badge 1" and "Badge 2" are displayed and they have the "Add to backpack" icon.  
    • Affected Branches:
      MOODLE_310_STABLE, MOODLE_39_STABLE
    • Pull from Repository:
    • Pull 3.11 Branch:
      MDL-69792-311
    • Pull Master Branch:
      MDL-69792-master
    • Sprint:
      Moppies Kanban

      Description

      Deprecate backpack.js functions and file that were deprecated in 3.7.  

       

      Another point to note is that badges_check_backpack_accessibility would need to be deprecated as well considering it's only used in badges/ajax.php which in turn is only called from backpack.js

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              sarjona Sara Arjona (@sarjona)
              Reporter:
              peterdias Peter Dias
              Peer reviewer:
              Carlos Escobedo
              Participants:
              Component watchers:
              Yuliya Bozhko, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 4 hours, 45 minutes
                  4h 45m