[MDL-69805] Database activity shows the comments option even if comments are disabled at site level - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.8.5, 3.9.2
Fix Version/s: 3.8.6, 3.9.3
Component/s: Database activity module
Labels:
- ci
- release_notes
- triaged

Affected Branches:
MOODLE_38_STABLE, MOODLE_39_STABLE
Fixed Branches:
MOODLE_38_STABLE, MOODLE_39_STABLE
Pull from Repository:
https://github.com/dravek/moodle
Pull 3.9 Branch:
~~MDL-69805~~-39
Pull 3.9 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_39_STABLE...dravek:MDL-69805-39
Pull Master Branch:
~~MDL-69805~~-master
Pull Master Diff URL:
https://github.com/moodle/moodle/compare/master...dravek:MDL-69805-master
Testing Instructions:
Hide

Basic testing instructions

Disable 'usecomments' in site config in Admin -> Advanced features

Create a new course

Add database module to the course

Confirm "Allow comments on entries" field is frozen

Save
Show
Basic testing instructions Disable 'usecomments' in site config in Admin -> Advanced features Create a new course Add database module to the course Confirm "Allow comments on entries" field is frozen Save

Description

The option "Allow comments on entries" is visible in the Database activity settings, even if Comments are turned off under Admin -> Advanced features.

This is a very confusing UI when you turn the option on, and nothing happens.

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

MDL-69805.jpg
4 kB
08/Oct/20 4:04 PM

Activity

People

Assignee:: David Matamoros

Reporter:: Tim Hunt

Peer reviewer:: Tim Hunt

Integrator:: Adrian Greeve

Tester:: Anna Carissa Sadia

Participants:: Adrian Greeve, Anna Carissa Sadia, CiBoT, David Matamoros, Eloy Lafuente (stronk7), Janelle Barcega, Tim Hunt

Component watchers:: Amaia Anabitarte, Carlos Escobedo, Laurent David, Mikel Martín Corrales, Sabina Abellan, Sara Arjona (@sarjona)

Votes:: 0 Vote for this issue

Watchers:: 6 Start watching this issue

Dates

Created:: 28/Sep/20 2:55 AM

Updated:: 04/Nov/20 5:01 PM

Resolved:: 09/Oct/20 5:48 PM

Fix Release Date:: 9/Nov/20

Time Tracking

Estimated:

Not Specified

Remaining:

Logged:

3h 50m