Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-69818

Restoring a feedback activity doesn't restore item dependency

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Automated testing

      1. Run unit tests and confirm they pass:

        vendor/bin/phpunit mod/feedback/tests/restore_date_test.php

      Manual testing

      1. Create two courses: Course1 and Course2.
      2. In Course1 create a feedback activity with two items dependent on each other:
        1. To create a dependency you must fill in the label field of the form for the question.
      3. Take a backup of the activity.
        1. Go to "Feedback administration > Backup" and click next for everything.
      4. In Course2 restore the backup.
        1. In course 1 go into the feedback activity and go to "Feedback administration > Restore".
        2. Pick the backup that you just created and follow each of the subsequent pages, picking the course 2 to restore into.
      5. Confirm, that in the restored activity both items have the same dependency as the original ones.
      Show
      Automated testing Run unit tests and confirm they pass: vendor/bin/phpunit mod/feedback/tests/restore_date_test.php Manual testing Create two courses: Course1 and Course2. In Course1 create a feedback activity with two items dependent on each other: To create a dependency you must fill in the label field of the form for the question. Take a backup of the activity. Go to "Feedback administration > Backup" and click next for everything. In Course2 restore the backup. In course 1 go into the feedback activity and go to "Feedback administration > Restore". Pick the backup that you just created and follow each of the subsequent pages, picking the course 2 to restore into. Confirm , that in the restored activity both items have the same dependency as the original ones.
    • Affected Branches:
      MOODLE_310_STABLE, MOODLE_38_STABLE, MOODLE_39_STABLE
    • Fixed Branches:
      MOODLE_38_STABLE, MOODLE_39_STABLE
    • Pull from Repository:
    • Pull 3.9 Branch:
      MOODLE_39_MDL-69818
    • Pull 3.10 Branch:
      MOODLE_310_MDL-69818
    • Pull Master Branch:
      master-MDL-69818

      Description

      Looks like it was created before MDL-52201 and closed as Cannot Reproduce.

      But the issue still exists in master. Here are some steps to replicate:

      1. Create two courses.
      2. In Course1 create a feedback activity with a couple of questions where the first question depends on another one.
      3. Take a backup of the activity.
      4. In course2 restore the backup.
      5. Confirm, that in the restored activity the first question doesn't depend on the second one.

      Screenshot:

        Attachments

          Activity

            People

            Assignee:
            mikhailgolenkov Mikhail Golenkov
            Reporter:
            mikhailgolenkov Mikhail Golenkov
            Peer reviewer:
            Dmitrii Metelkin Dmitrii Metelkin
            Integrator:
            Adrian Greeve Adrian Greeve
            Tester:
            Anna Carissa Sadia Anna Carissa Sadia
            Participants:
            Component watchers:
            Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              9/Nov/20

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 hour, 30 minutes
                1h 30m