Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-69855

When private reply is sent via email, the email includes a "reply" button

    XMLWordPrintable

Details

    • MOODLE_310_STABLE, MOODLE_311_STABLE, MOODLE_39_STABLE, MOODLE_400_STABLE
    • MOODLE_310_STABLE, MOODLE_311_STABLE
    • MDL-69855-310
    • MDL-69855-311
    • MDL-69855-master
    • Hide
      Prerequisites
      1. Outgoing mail setup. Easier to use Mailcatcher or Mailhog.
      Setup
      1. Create a course with a forum. Enrol a teacher and two students s1 and s2.
      2. Log in as s1.
      3. Open the user menu > Preferences > Forum preferences
      4. Make sure that "Email digest type" preference is set to "No digest"
      5. Go to the forum and create a discussion
      6. Log in as s2 and create a discussion.
      7. Open the user menu > Preferences > Forum preferences
      8. Make sure that "Email digest type" preference is set to "Complete"
      9. Go to the forum and create a discussion
      10. Log in as a teacher and post two replies for each discussion:
        • Reply 1: Regular reply
        • Reply 2: Private reply ("Reply privately" is ticked)
          Note: Recommended to tick "Send forum post notifications with no editing-time delay" as well to send the email right away.
      Test: Forum post email
      1. Run cron. You should see the emails for s1.

        php admin/cli/cron.php

      2. Check the regular reply for s1.
      3. Confirm that the regular reply has a "Reply" link.
      4. Check the Plain text version of the email.
      5. Confirm that you see the text "This is a copy of a message posted in [COURSE NAME]."
      6. Confirm that you see the text "To reply click on this link:" followed by the reply URL.
      7. Check the private reply for s1.
      8. Confirm that the private reply does not have a "Reply" link.
      9. Check the Plain text version of the private email.
      10. Confirm that you see the text "This is a copy of a message posted in [COURSE NAME]."
      11. Confirm that you DO NOT see the text "To reply click on this link:" and the reply URL.
      Test: Forum email digest
      1. Using your preferred Database management tool, go to the "mdl_task_adhoc". You should see an entry there for the "\mod_forum\task\send_user_digests" ad-hoc task.
      2. Edit the record and set the "nextruntime" field to 0 and save the changes.
      3. Run cron again. You should see the digest email for s2.
      4. Check the HTML version of the email. (No need to check the plain text version because it does not include a reply URL at all)
      5. Confirm that the regular reply has a "Reply" link included.
      6. Confirm that the private reply does not have a "Reply" link.
      Show
      Prerequisites Outgoing mail setup. Easier to use Mailcatcher or Mailhog. Setup Create a course with a forum. Enrol a teacher and two students s1 and s2. Log in as s1. Open the user menu > Preferences > Forum preferences Make sure that " Email digest type " preference is set to " No digest " Go to the forum and create a discussion Log in as s2 and create a discussion. Open the user menu > Preferences > Forum preferences Make sure that " Email digest type " preference is set to " Complete " Go to the forum and create a discussion Log in as a teacher and post two replies for each discussion: Reply 1: Regular reply Reply 2: Private reply ("Reply privately" is ticked) Note: Recommended to tick " Send forum post notifications with no editing-time delay " as well to send the email right away. Test: Forum post email Run cron. You should see the emails for s1. php admin/cli/cron.php Check the regular reply for s1. Confirm that the regular reply has a "Reply" link. Check the Plain text version of the email. Confirm that you see the text " This is a copy of a message posted in [COURSE NAME] . " Confirm that you see the text " To reply click on this link: " followed by the reply URL. Check the private reply for s1. Confirm that the private reply does not have a "Reply" link. Check the Plain text version of the private email. Confirm that you see the text " This is a copy of a message posted in [COURSE NAME] . " Confirm that you DO NOT see the text " To reply click on this link: " and the reply URL. Test: Forum email digest Using your preferred Database management tool, go to the " mdl_task_adhoc ". You should see an entry there for the " \mod_forum\task\send_user_digests " ad-hoc task. Edit the record and set the " nextruntime " field to 0 and save the changes. Run cron again. You should see the digest email for s2. Check the HTML version of the email. (No need to check the plain text version because it does not include a reply URL at all) Confirm that the regular reply has a " Reply " link included. Confirm that the private reply does not have a " Reply " link.
    • 0
    • HQ Team International Sprint 6, HQ Team International Sprint 7, HQ Team International Sprint 8

    Description

      When a teacher's private reply is sent via email subscription, the email includes a "reply" link, even though the provate message cannot be replied to.  Clicking on that link brings up a "Sorry, you are not allowed to post to this forum" message.

      Attachments

        1. MDL-69855_Email digest.png
          MDL-69855_Email digest.png
          77 kB
        2. MDL-69855_Step 10-11.png
          MDL-69855_Step 10-11.png
          97 kB
        3. MDL-69855_Step 3.png
          MDL-69855_Step 3.png
          82 kB
        4. MDL-69855_Step 5-6.png
          MDL-69855_Step 5-6.png
          90 kB
        5. MDL-69855_Step 8.png
          MDL-69855_Step 8.png
          89 kB

        Issue Links

          Activity

            People

              jpataleta Jun Pataleta
              stencel Przemyslaw Stencel
              Michael Hawkins Michael Hawkins
              Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
              Angelia Dela Cruz Angelia Dela Cruz
              Andrew Lyons, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                13/Sep/21

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 4 hours, 55 minutes
                  4h 55m