Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-69878

Always show the close button on the message drawer

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. login as admin
      2. Click the message icon
      3. This will open the message drawer
      4. Click the close icon in the top right of the message drawer
      5. Verify this closes the message drawer

      Test the Message drawer focus order from the navbar

      1. Login as admin
      2. Navigate to any Moodle page
      3. Use your keyboard to tab to the messaging button
      4. Hit enter to open the message drawer
      5. Verify you can open the message drawer
      6. Verify you can hit enter again to close the message drawer
      7. Hit enter to open the message drawer
      8. Hit tab again after you have opened the message drawer
      9. Verify the focus is now on the message drawer close button
      10. Hit SHIFT-tab to move backwards
      11. Verify the focus is returned to the message drawer toggle button
      12. Hit tab again to focus on the drawer close button
      13. Hit enter and verify this closes the navdrawer and puts the focus back on the messaging button
      Show
      login as admin Click the message icon This will open the message drawer Click the close icon in the top right of the message drawer Verify this closes the message drawer Test the Message drawer focus order from the navbar Login as admin Navigate to any Moodle page Use your keyboard to tab to the messaging button Hit enter to open the message drawer Verify you can open the message drawer Verify you can hit enter again to close the message drawer Hit enter to open the message drawer Hit tab again after you have opened the message drawer Verify the focus is now on the message drawer close button Hit SHIFT-tab to move backwards Verify the focus is returned to the message drawer toggle button Hit tab again to focus on the drawer close button Hit enter and verify this closes the navdrawer and puts the focus back on the messaging button
    • Affected Branches:
      MOODLE_400_STABLE
    • Fixed Branches:
      MOODLE_311_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-69878-master
    • Sprint:
      Moppies Kanban

      Description

      To open the message drawer you have to click the message icon in the page navbar, and to close it you need to click the message icon again. This has been reported to be non-intuitive since dialogues have a close button within the dialogue.

      The close button does appear on small devices with a maximum width of 767px

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              basbrands Bas Brands
              Reporter:
              basbrands Bas Brands
              Peer reviewer:
              Amaia Anabitarte
              Integrator:
              Sara Arjona (@sarjona)
              Tester:
              Janelle Barcega
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona), Barbara Ramiro, Bas Brands
              Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                10/May/21

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 3 hours, 50 minutes
                  3h 50m