[MDL-69878] Always show the close button on the message drawer - Moodle Tracker

XML

Word

Printable

Details

Type: Improvement
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 4.0
Fix Version/s: 3.11
Component/s: Messages, Usability
Labels:

Affected Branches:
MOODLE_400_STABLE
Fixed Branches:
MOODLE_311_STABLE
Pull from Repository:
git://github.com/bmbrands/moodle.git
Pull Master Branch:
~~MDL-69878~~-master
Pull Master Diff URL:
https://github.com/bmbrands/moodle/compare/d330035f11...MDL-69878-master
Testing Instructions:
Hide

login as admin

Click the message icon

This will open the message drawer

Click the close icon in the top right of the message drawer

Verify this closes the message drawer

Test the Message drawer focus order from the navbar

Login as admin

Navigate to any Moodle page

Use your keyboard to tab to the messaging button

Hit enter to open the message drawer

Verify you can open the message drawer

Verify you can hit enter again to close the message drawer

Hit enter to open the message drawer

Hit tab again after you have opened the message drawer

Verify the focus is now on the message drawer close button

Hit SHIFT-tab to move backwards

Verify the focus is returned to the message drawer toggle button

Hit tab again to focus on the drawer close button

Hit enter and verify this closes the navdrawer and puts the focus back on the messaging button
Show
login as admin Click the message icon This will open the message drawer Click the close icon in the top right of the message drawer Verify this closes the message drawer Test the Message drawer focus order from the navbar Login as admin Navigate to any Moodle page Use your keyboard to tab to the messaging button Hit enter to open the message drawer Verify you can open the message drawer Verify you can hit enter again to close the message drawer Hit enter to open the message drawer Hit tab again after you have opened the message drawer Verify the focus is now on the message drawer close button Hit SHIFT-tab to move backwards Verify the focus is returned to the message drawer toggle button Hit tab again to focus on the drawer close button Hit enter and verify this closes the navdrawer and puts the focus back on the messaging button

Sprint:
Moppies Kanban

Description

To open the message drawer you have to click the message icon in the page navbar, and to close it you need to click the message icon again. This has been reported to be non-intuitive since dialogues have a close button within the dialogue.

The close button does appear on small devices with a maximum width of 767px

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

image-2020-11-26-10-08-52-302.png
105 kB
26/Nov/20 10:08 AM

Issue Links

has a non-specific relationship to

MDL-70880 Closing messaging drawer by pressing X scrolls page to top

Closed

Activity

People

Assignee:: Bas Brands

Reporter:: Bas Brands

Peer reviewer:: Amaia Anabitarte

Integrator:: Sara Arjona (@sarjona)

Tester:: Janelle Barcega

Participants:: Amaia Anabitarte, Andrew Lyons, Bas Brands, CiBoT, Eloy Lafuente (stronk7), Janelle Barcega, Jun Pataleta, Sara Arjona (@sarjona)

Component watchers:: David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo, Huong Nguyen, Barbara Ramiro, Bas Brands, Mathew May, David Woloszyn, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo

Votes:: 0 Vote for this issue

Watchers:: 8 Start watching this issue

Dates

Created:: 07/Oct/20 4:51 PM

Updated:: 07/May/21 6:45 PM

Resolved:: 27/Nov/20 4:02 PM

Fix Release Date:: 17/May/21

Time Tracking

Estimated:

Not Specified

Remaining:

Logged:

3h 50m