Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-69882

Final deprecation of phpunit/dbunit methods in advanced_testcase

XMLWordPrintable

    • Icon: Task Task
    • Resolution: Fixed
    • Icon: Minor Minor
    • 4.2
    • 3.9.20, 3.10
    • Unit tests
    • MOODLE_310_STABLE, MOODLE_39_STABLE
    • MOODLE_402_STABLE
    • Hide
      1. Run the following:

        $ git grep -A1 "\(createXMLDataSet\|createCsvDataSet\|createArrayDataSet\|loadDataSet\)"
        

      2. Confirm the only results are remaining function stubs that throw exceptions, and upgrade notes documenting removal
      Show
      Run the following: $ git grep -A1 "\(createXMLDataSet\|createCsvDataSet\|createArrayDataSet\|loadDataSet\)" Confirm the only results are remaining function stubs that throw exceptions, and upgrade notes documenting removal

      Part of MDL-67673 and MDL-64600, phpunit/dbunit was removed from core (because it was not available anymore). That implied removing some advanced_testcase methods using it and switching to our own phpunit_dataset class.

      The methods to be completely removed here are:

      • createXMLDataSet()
      • createCsvDataSet()
      • createArrayDataSet()
      • loadDataSet()

      and, also, the associated unit tests covering the current deprecation debugging.

      In lib/upgrade.txt you can find information about the deprecation replacements.

      At the end, there shouldn't be any occurrence of any of the above in core (or "DBUnit" / "dbunit" in general).

        1. MDL-69882.gif
          3.44 MB
          Ron Carl Alfon Yu

            pholden Paul Holden
            stronk7 Eloy Lafuente (stronk7)
            Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
            Ilya Tregubov Ilya Tregubov
            Ron Carl Alfon Yu Ron Carl Alfon Yu
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 35 minutes
                35m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.