Details
-
Bug
-
Status: Closed
-
Minor
-
Resolution: Fixed
-
3.9.2
-
MOODLE_39_STABLE
-
MOODLE_38_STABLE, MOODLE_39_STABLE
-
MDL-69900-39 -
MDL-69900-master -
Test
- Login as Admin.
- Go to Site home.
- Click on 'Restore' in the settings menu ('settings' cog)
- In the Files area upload the attached sample IMS Common Cartridge package (exploring_the_english_language_imscc.zip
)
(Alternatively you can download a sample IMS Common Cartridge package from http://openlearn.open.ac.uk/ by following the instructions in the description of this issue) - After the file is added in the Files area, click on "Restore".
- In the 'Confirm' restore step, click 'Continue'.
- In the 'Destination' restore step:
- Select 'Restore as a new course'
- Select 'Miscellaneous' as a course category
- Click 'Continue' (below the category selection)
- Confirm you have been successfully directed to the 'Settings' restore step and you don't see any " Deprecated: Non-static method cc2moodle::critical_error() should not be called statically" error (if debugging is enabled, some warnings might be displayed).
- Go through the rest of the restore steps while keeping the default settings (Next > Next > Perform restore)
- Confirm the course have been successfully restored.
Test Login as Admin. Go to Site home. Click on 'Restore' in the settings menu ('settings' cog) In the Files area upload the attached sample IMS Common Cartridge package ( exploring_the_english_language_imscc.zip ) (Alternatively you can download a sample IMS Common Cartridge package from http://openlearn.open.ac.uk/ by following the instructions in the description of this issue) After the file is added in the Files area, click on "Restore". In the 'Confirm' restore step, click 'Continue'. In the 'Destination' restore step: Select 'Restore as a new course' Select 'Miscellaneous' as a course category Click 'Continue' (below the category selection) Confirm you have been successfully directed to the 'Settings' restore step and you don't see any " Deprecated: Non-static method cc2moodle::critical_error() should not be called statically" error (if debugging is enabled, some warnings might be displayed). Go through the rest of the restore steps while keeping the default settings (Next > Next > Perform restore) Confirm the course have been successfully restored.
Description
When trying to restore an IMS CC file into Moodle, if the code encounters an error it will try to call cc2moodle::critical_error() but it is not a static method.
Replication steps:
- Download a sample IMS Common Cartridge package from http://openlearn.open.ac.uk/ (Click one of the courses and above the comments, select the "Alternative formats" tab. IMS Common Cartridge should be available there).
- Try to restore the file. When restoring it should say that it is restoring a IMS CC 1.0 file.
- Almost all of the packages here are not actually 1.0 and so should hit the above error method.
