[MDL-69939] Remove use of 'true' and 'false' in db/services.php - Moodle Tracker

XML

Word

Printable

Affected Branches:
MOODLE_310_STABLE, MOODLE_311_STABLE, MOODLE_35_STABLE, MOODLE_37_STABLE, MOODLE_38_STABLE, MOODLE_39_STABLE, MOODLE_400_STABLE
Fixed Branches:
MOODLE_311_STABLE, MOODLE_400_STABLE
Pull from Repository:
https://github.com/paulholden/moodle.git
Pull 3.11 Branch:
~~MDL-69939~~-311
Pull 3.11 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_311_STABLE...paulholden:MDL-69939-311
Pull 4.0 Branch:
~~MDL-69939~~-400
Pull 4.0 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_400_STABLE...paulholden:MDL-69939-400
Pull Master Branch:
~~MDL-69939~~
Pull Master Diff URL:
https://github.com/moodle/moodle/compare/master...paulholden:MDL-69939
Testing Instructions:
Hide

Confirm the following returns no matches:

$ git grep "'true'" -- '*.php' | grep services
Show
Confirm the following returns no matches: $ git grep "'true'" -- '*.php' | grep services

There are a couple of places which have this madness.
We must remember that:

'false' == true

See:

2049 im:master> gg "'true'" | grep php | grep service

lib/db/services.php:        'ajax'        => 'true'

lib/db/services.php:        'ajax'        => 'true'

lib/db/services.php:        'ajax'        => 'true'

lib/db/services.php:        'ajax'        => 'true'

lib/db/services.php:        'ajax'        => 'true'

lib/db/services.php:        'ajax'        => 'true'

lib/db/services.php:        'ajax'          => 'true',

lib/db/services.php:        'ajax'          => 'true',

lib/db/services.php:        'ajax'          => 'true',

lib/db/services.php:        'ajax'          => 'true',

lib/db/services.php:        'ajax'          => 'true',

lib/db/services.php:        'ajax'        => 'true',

media/player/videojs/db/services.php:        'ajax'          => 'true',

In this case they're all fine, and there are no instances of 'false', but we should still fix it.

Discovered while testing

MDL-74287 Early (web) installation steps lead to table does not exist errors

Participants:: Andrew Lyons, Angelia Dela Cruz, CiBoT, Ferran Recio, Jun Pataleta, Paul Holden, Simey Lameze

Component watchers:: Juan Leyva, David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo

Estimated:

Not Specified

Remaining:

Logged:

1h 43m