Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-69962

Consistent included files increase after MDL-69739

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.10, 4.0
    • Fix Version/s: 3.10
    • Component/s: Performance, User Tours
    • Labels:
    • Testing Instructions:
      Hide

      1. Log in as Admin
      2. Navigate to Site Administration > Development > Debugging
      3. Tick 'Performance info'
      4. Save changes
      5. Navigate to Site Administration > Appearance > User tours and make sure that there are no tours
      6. Navigate to Dashboard and make a note of the number of included files (displayed in the footer)
      7. Navigate to Site Administration > Appearance > User tours
      8. Click 'Create a new tour'
      9. Give the tour a name and tick the 'Tour is enabled' checkbox
      10. Save the changes
      11. Click on the name of your new tour
      12. Click the new step link
      13. Set Target type to 'Display in middle of page', and add a Title and Content
      14. Save the changes
      15. Navigate to Dashboard and check the number of included files is more than before

      Show
      1. Log in as Admin 2. Navigate to Site Administration > Development > Debugging 3. Tick 'Performance info' 4. Save changes 5. Navigate to Site Administration > Appearance > User tours and make sure that there are no tours 6. Navigate to Dashboard and make a note of the number of included files (displayed in the footer) 7. Navigate to Site Administration > Appearance > User tours 8. Click 'Create a new tour' 9. Give the tour a name and tick the 'Tour is enabled' checkbox 10. Save the changes 11. Click on the name of your new tour 12. Click the new step link 13. Set Target type to 'Display in middle of page', and add a Title and Content 14. Save the changes 15. Navigate to Dashboard and check the number of included files is more than before
    • Affected Branches:
      MOODLE_310_STABLE, MOODLE_400_STABLE
    • Fixed Branches:
      MOODLE_310_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-69962-master

      Description

      Edited: Eloy, to point to the correct issue.

      It seems that MDL-69739 has come with a small, but consistent, increase in files included for basically all requests (9 more files included).

      Surely this is acceptable (~2%) because of the new subsystem (component) creation and won't require any action, but at very least it needs to be checked and confirmed. And, if possible, reduced.

      Ciao

      Link (will last only 15 days): https://performance.stronk7.com/?timestamps%5B%5D=1602840870396&timestamps%5B%5D=1602839669115&n=1

      PDF: performance.stronk7.com.pdf

        Attachments

        1. image-2020-10-20-12-28-02-037.png
          86 kB
          Janelle Barcega
        2. performance.stronk7.com.pdf
          141 kB
          Eloy Lafuente (stronk7)

          Issue Links

            Activity

              People

              Assignee:
              kransom Katie Ransom
              Reporter:
              stronk7 Eloy Lafuente (stronk7)
              Peer reviewer:
              Sam Marshall
              Integrator:
              Víctor Déniz Falcón
              Tester:
              Janelle Barcega
              Participants:
              Component watchers:
              Matteo Scaramuccia, Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                9/Nov/20

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 hour
                  1h