Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-69983

Asynchronous course backups should be stored in user backup area

XMLWordPrintable

    • MOODLE_39_STABLE, MOODLE_401_STABLE, MOODLE_402_STABLE
    • MOODLE_401_STABLE, MOODLE_402_STABLE
    • MDL-69983-401
    • MDL-69983-master
    • Hide
      1. Test instructions as admin.
      2. Save course A without user -> course with status process pending should be displayed in the user's save area (ending time-nu.mbz)
      3. Save course B with users -> course with status process pending should be displayed in the course's save area (ending time.mbz)
      4. Save course C with users and anonymization -> course with status process pending should be displayed in the user's security area (ending time-an.mbz)
      5. Run cron and all courses should have the status Backup successful.
      6. on the backup / restorefile.php page of course A nothing should be displayed in the course area and two successful backups in the user area (course A and course C)
      7. on the backup / restorefile.php page of course B, the successful backup of course B should be displayed in the course area and two successful backups of course A and course C in the user area
      8. Perform the above steps on an activity
      Show
      Test instructions as admin. Save course A without user -> course with status process pending should be displayed in the user's save area (ending time-nu.mbz) Save course B with users -> course with status process pending should be displayed in the course's save area (ending time.mbz) Save course C with users and anonymization -> course with status process pending should be displayed in the user's security area (ending time-an.mbz) Run cron and all courses should have the status Backup successful. on the backup / restorefile.php page of course A nothing should be displayed in the course area and two successful backups in the user area (course A and course C) on the backup / restorefile.php page of course B, the successful backup of course B should be displayed in the course area and two successful backups of course A and course C in the user area Perform the above steps on an activity
    • 1
    • Team Hedgehog 2023 Sprint 2.1, Team Hedgehog 2023 Sprint 2.2, Team Hedgehog 2023 Sprint 2.3
    • Small

      We enabled asynchronous backups in Site Administration / Courses / Backups / Asynchronous backup/restore. Before the backup files without user info or the anonymise functionality were saved in the user backup area. Asynchronous backups are saved in the course backup area. This is incomprehensible for our users. Is there a reason for this behavior?
      This also leads to the problem that course backups are deleted when a course is deleted. This behavior is not expected.

      Couldn't we change backup/util/helper/backup_helper.class.php lines 328-337?

      // Backups without user info or with the anonymise functionality        // enabled are sent to user's "user_backup"       // file area. Maintenance of such area is responsibility of        // the user via corresponding file manager frontend        if (($backupmode == backup::MODE_GENERAL || $backupmode == backup::MODE_ASYNC) && (!$hasusers || $isannon)) {                $ctxid     = context_user::instance($userid)->id;                $component = 'user';               $filearea  = 'backup';                $itemid    = 0;        }

       

        1. course_anon_users.png
          course_anon_users.png
          141 kB
        2. course_no_users.png
          course_no_users.png
          132 kB
        3. course_with_users.png
          course_with_users.png
          151 kB
        4. MDL-69983.png
          MDL-69983.png
          932 kB

            franziskah Franziska Hübler
            franziskah Franziska Hübler
            David Woloszyn David Woloszyn
            Ilya Tregubov Ilya Tregubov
            Ron Carl Alfon Yu Ron Carl Alfon Yu
            Votes:
            5 Vote for this issue
            Watchers:
            9 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 7 hours, 11 minutes
                7h 11m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.