Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-69995

On Backup and Restore pages, icons after activities have no padding

XMLWordPrintable

    • MOODLE_39_STABLE
    • MOODLE_38_STABLE, MOODLE_39_STABLE
    • MDL-69995-master
    • Hide
      1. Test in Boost and Classic, and in a RTL language, too.
      2. In a course with activites, initiate a backup.
      3. Go to the second step (where there's the All / None (Show type options) handles) using the "Next" button.
      4. Verify each activity icon behind the activity name has a padding and is not sticking directly to the activity name.
      5. Create a backup mbz to restore.
      6. In a course page, choose "Restore" in the activity menu to restore that backup.
      7. After having provided the backup file and chosen the course where to restore, go to the second step (where there's the All / None (Show type options) handles) using the "Next" button.
      8. Verify each activity icon behind the activity name has a padding and is not sticking directly to the activity name.
      Show
      Test in Boost and Classic, and in a RTL language, too. In a course with activites, initiate a backup. Go to the second step (where there's the All / None (Show type options) handles) using the "Next" button. Verify each activity icon behind the activity name has a padding and is not sticking directly to the activity name. Create a backup mbz to restore. In a course page, choose "Restore" in the activity menu to restore that backup. After having provided the backup file and chosen the course where to restore, go to the second step (where there's the All / None (Show type options) handles) using the "Next" button. Verify each activity icon behind the activity name has a padding and is not sticking directly to the activity name.

      On backup and restore pages that list activities, the icon is placed after the name, but the margin is added to it on the wrong side, so it attaches directly to the text.

       

      They have the .icon-post class which appears to be intended for exactly this case, but as far as I can tell there's not styles attached.

      Reversing the icon margin so it's on the left hand side if icon-post is used seems like it would be a nice visual improvement.

       

      Something like:

      .icon.icon-post

      { margin-right: 0; margin-left: 6px; }


       

       

        1. Screen Shot 2020-10-21 at 10.40.08.png
          Screen Shot 2020-10-21 at 10.40.08.png
          122 kB
        2. Screen Shot 2020-10-21 at 10.54.30.png
          Screen Shot 2020-10-21 at 10.54.30.png
          108 kB
        3. MDL-69995.jpg
          MDL-69995.jpg
          38 kB

            lucaboesch Luca Bösch
            bawjaws David Scotson
            Mihail Geshoski Mihail Geshoski
            Andrew Lyons Andrew Lyons
            Anna Carissa Sadia Anna Carissa Sadia
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 3 hours, 25 minutes
                3h 25m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.