Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-70004

Invalid role attribute in the label for the "Clear my choice" option

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      Prerequisite
      1. Axe tool
      Accessibility testing
      1. Create a multiple-choice question in a course.
      2. Preview the multiple-choice question.
      3. Open the axe tool on your browser's developer tools.
      4. Analyse the page using the axe tool.
      5. Confirm that there are no violations related to the "Clear my choice" label
      Manual tests
      1. Create at least one more multiple-choice question.
      2. Create a quiz and add these questions into the quiz. Make sure that the questions have a page break in between them.
      3. Preview the quiz.
      4. Tab onto one of the options of the multiple-choice question. This should highlight the first option but not actually select it.
      5. Tab again.
      6. Confirm that the focus goes to the "Check" button.
      7. Press Shift-Tab.
      8. Confirm that the focus goes back to the options in the question.
      9. Press up/down.
      10. Confirm that the "Clear my choice" link comes up.
      11. Press tab.
      12. Confirm that the focus goes to the "Clear my choice" link.
      13. Confirm that you see a blue focus outline around the "Clear my choice" link.
      14. Take note of the currently selected option and click on "Next page"
      15. Then click on "Previous page" to go back to the question.
      16. Confirm that the option that was selected earlier is still selected.
      17. Confirm that the "Clear my choice" link is still visible.
      18. Press "Clear my choice"
      19. Confirm that it disappears and that the selected option becomes deselected.
      20. Press "Next page"
      21. Press "Previous page"
      22. Confirm that there is still no selected option for the multiple-choice question.
      23. Confirm that the "Clear my choice" link is still hidden.
      Show
      Prerequisite Axe tool Accessibility testing Create a multiple-choice question in a course. Preview the multiple-choice question. Open the axe tool on your browser's developer tools. Analyse the page using the axe tool. Confirm that there are no violations related to the "Clear my choice" label Manual tests Create at least one more multiple-choice question. Create a quiz and add these questions into the quiz. Make sure that the questions have a page break in between them. Preview the quiz. Tab onto one of the options of the multiple-choice question. This should highlight the first option but not actually select it. Tab again. Confirm that the focus goes to the " Check " button. Press Shift-Tab. Confirm that the focus goes back to the options in the question. Press up/down. Confirm that the " Clear my choice " link comes up. Press tab. Confirm that the focus goes to the " Clear my choice " link. Confirm that you see a blue focus outline around the " Clear my choice " link. Take note of the currently selected option and click on " Next page " Then click on " Previous page " to go back to the question. Confirm that the option that was selected earlier is still selected. Confirm that the " Clear my choice " link is still visible. Press " Clear my choice " Confirm that it disappears and that the selected option becomes deselected. Press " Next page " Press " Previous page " Confirm that there is still no selected option for the multiple-choice question. Confirm that the " Clear my choice " link is still hidden.
    • Affected Branches:
      MOODLE_38_STABLE
    • Fixed Branches:
      MOODLE_38_STABLE, MOODLE_39_STABLE
    • Pull 3.9 Branch:
    • Pull 3.10 Branch:
      MDL-70004-310
    • Pull Master Branch:
      MDL-70004-master

      Description

      The "Clear my choice"'s label in qtype_multichoice has a role attribute. Apparently, the role attribute is not allowed for labels.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              jpataleta Jun Pataleta
              Reporter:
              jpataleta Jun Pataleta
              Peer reviewer:
              Simey Lameze
              Integrator:
              Andrew Nicols
              Tester:
              Janelle Barcega
              Participants:
              Component watchers:
              Andrew Nicols, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Tim Hunt, Andrew Nicols, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                9/Nov/20

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 6 hours, 4 minutes
                  6h 4m