Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-70014

Random behat failures with tool_customlang scenarios (timeout)

    XMLWordPrintable

Details

    • MOODLE_310_STABLE, MOODLE_311_STABLE, MOODLE_39_STABLE, MOODLE_400_STABLE
    • MOODLE_310_STABLE, MOODLE_311_STABLE, MOODLE_39_STABLE
    • Hide

      Regression testing

      1. Go to Admin > general > Language customisation
      2. Choose "English"
      3. Press the "Open language pack for editing" button.
      4. Verify that a progress bar appear with text "Language pack loaded"text once finished.
      5. Press the "continue" button.
      6. Verify that now you are in the "Filter strings" page.
      7. Verify that in the menu list of components, there is a "mod" bold element and, under it, there are multiple files, one for every mod plugin (assign.php, assignment.php, bitgluebutton.php...). And many more, more bold elements (auth, blocks...) all of them having various .php under them.
      8. Select in the menu list the "mod -> forum.php" element and click the "Show strings" button.
      9. Verify that after the filter, a long list of strings is shown, with an edit box on the right.
      10. Find the "addreply" string and, in the edit box type "Answer to the POST"
      11. Go to the end of the page and press the "Apply changes and continue editing" button.
      12. Verify that the "addreply" element now has a blue background and that the "Answer to the POST" text is there, in the edit box.
      13. Go to the end of the page and press the "Save changes to the language pack" button.
      14. Verify that in the confirmation page there is the "There are 1 modified strings" text.
      15. Press "Continue" (that will save the customised lang pack).
      16. Go to any forum in any course in the site (create one if needed).
      17. Click the "Reply" link for any of the posts in the forum, then "Advanced"
      18. Verify that in the navigation bar you can see the "Answer to the POST" text that was customised some steps above (see screenshot).
      19. That's all, the language customisation is working ok and the changes in this issue don't affect it.

      Automated testing

      • The repetitions that have been executed as part of this issue, both with super-slow local oracle environment and @ CI (see ToBiC comment) should be enough. Zero failures where they used to happen lots of time.
      Show
      Regression testing Go to Admin > general > Language customisation Choose "English" Press the "Open language pack for editing" button. Verify that a progress bar appear with text "Language pack loaded"text once finished. Press the "continue" button. Verify that now you are in the "Filter strings" page. Verify that in the menu list of components, there is a "mod" bold element and, under it, there are multiple files, one for every mod plugin (assign.php, assignment.php, bitgluebutton.php...). And many more, more bold elements (auth, blocks...) all of them having various .php under them. Select in the menu list the "mod -> forum.php" element and click the "Show strings" button. Verify that after the filter, a long list of strings is shown, with an edit box on the right. Find the "addreply" string and, in the edit box type "Answer to the POST" Go to the end of the page and press the "Apply changes and continue editing" button. Verify that the "addreply" element now has a blue background and that the "Answer to the POST" text is there, in the edit box. Go to the end of the page and press the "Save changes to the language pack" button. Verify that in the confirmation page there is the "There are 1 modified strings" text. Press "Continue" (that will save the customised lang pack). Go to any forum in any course in the site (create one if needed). Click the "Reply" link for any of the posts in the forum, then "Advanced" Verify that in the navigation bar you can see the "Answer to the POST" text that was customised some steps above (see screenshot). That's all, the language customisation is working ok and the changes in this issue don't affect it. Automated testing The repetitions that have been executed as part of this issue, both with super-slow local oracle environment and @ CI (see ToBiC comment) should be enough. Zero failures where they used to happen lots of time.

    Description

      There is a variété of scenarios, all them related with the tool_customlang plugin that have started to fail recently (310_STABLE and up). It's specially noticeable with MSSQL / Oracle databases and/or when the worker is busy / slow.

      All them come from the new export () and import () language strings features.

      The error seems to be that the "load lang" intermediate step that happens in some of those scenarios takes too long and selenium/behat timeouts.

      It affects a number of scenarios (sometimes only 1 fails, other they are 9...).

      Some links:

      And the output for the failure (apart from the scenario information that is varying):

      001 Scenario: Import a PHP file to add a new core lang customization # /var/www/html/admin/tool/customlang/tests/behat/import_files.feature:15
            And I click on "Import custom strings" "button"                # /var/www/html/admin/tool/customlang/tests/behat/import_files.feature:11
              timeout
                (Session info: chrome=79.0.3945.117)
                (Driver info: chromedriver=79.0.3945.36 (3582db32b33893869b8c1339e8f4d9ed1816f143-refs/branch-heads/3945@{#614}),platform=Linux 4.15.0-120-generic x86_64) (WebDriver\Exception\Timeout)
      

      Attachments

        Issue Links

          Activity

            People

              stronk7 Eloy Lafuente (stronk7)
              stronk7 Eloy Lafuente (stronk7)
              David Mudrák (@mudrd8mz) David Mudrák (@mudrd8mz)
              Jun Pataleta Jun Pataleta
              Gladys Basiana Gladys Basiana
              Votes:
              2 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 day, 10 minutes
                  1d 10m

                  Clockify

                    Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.