Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-70033

Download course content modal can't be triggered by teachers with keyboard events in the Classic theme

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • 3.10
    • 3.10
    • Course
    • MOODLE_310_STABLE
    • MOODLE_310_STABLE
    • MDL-70033-master-2
    • Hide

      Setup

      1. Log in as admin.
      2. Set the site theme to Classic.
      3. Navigate to Site admin > Courses and set the following:
        1. Course default setting for "Enable download course content" to "Yes".
        2. Check the "Download course content feature available" checkbox so it is available.
      4. Press save changes.
      5. If you don't already have a course with some activities added, create one.

      Testing

      1. Navigate to the course homepage as admin or teacher and let the page finish loading.
      2. In course administration on the left of the page, click on "Download course content".
      3. CONFIRM you see the download modal pop up, and CONFIRM you are not redirected away from the course homepage.
      4. Press "Download" in the modal, and CONFIRM it triggers the download of the course content zip file (either downloading the file, or prompting you to do so).
      5. Still on the course homepage, navigate to the "Download course content" item in course administration using your keyboard, then press enter.
      6. CONFIRM you again see the download modal pop up, and CONFIRM you are not redirected away from the course homepage.
      7. Press "Download" in the modal, and CONFIRM it triggers the download of the course content zip file.
      8. Again on the course homepage, navigate to the "Download course content" item in course administration using your keyboard, then press space.
      9. CONFIRM you again see the download modal pop up, and CONFIRM you are not redirected away from the course homepage.
      10. Press "Download" in the modal, and CONFIRM it triggers the download of the course content zip file.
      11. Switch the site theme to Boost.
      12. Repeat steps 1-10, using Boost's course action menu (cog) in place of Classic's course administration menu.
      Show
      Setup Log in as admin. Set the site theme to Classic. Navigate to Site admin > Courses and set the following: Course default setting for "Enable download course content" to "Yes". Check the "Download course content feature available" checkbox so it is available. Press save changes. If you don't already have a course with some activities added, create one. Testing Navigate to the course homepage as admin or teacher and let the page finish loading. In course administration on the left of the page, click on "Download course content". CONFIRM you see the download modal pop up, and CONFIRM you are not redirected away from the course homepage. Press "Download" in the modal, and CONFIRM it triggers the download of the course content zip file (either downloading the file, or prompting you to do so). Still on the course homepage, navigate to the "Download course content" item in course administration using your keyboard, then press enter . CONFIRM you again see the download modal pop up, and CONFIRM you are not redirected away from the course homepage. Press "Download" in the modal, and CONFIRM it triggers the download of the course content zip file. Again on the course homepage, navigate to the "Download course content" item in course administration using your keyboard, then press space . CONFIRM you again see the download modal pop up, and CONFIRM you are not redirected away from the course homepage. Press "Download" in the modal, and CONFIRM it triggers the download of the course content zip file. Switch the site theme to Boost. Repeat steps 1-10, using Boost's course action menu (cog) in place of Classic's course administration menu.

      There is some jquery event handling in lib/amd/src/tree.js, which stops event propagation in places such as the course admin links. This has already been fixed for click events in MDL-69559, but not for keyboard events (which are slightly more involved).

      The result is that when a teacher in the Classic theme tries to press "Download course content", instead of triggering the download modal, it will simply redirect to the href on that element.

      The page being redirected to will still allow the download, so the feature is still available, but ideally it should work as intended and be consistent with how it acts with a mouse click.

        1. MDL-70033_Boost.jpg
          MDL-70033_Boost.jpg
          59 kB
        2. MDL-70033_Classic.jpg
          MDL-70033_Classic.jpg
          57 kB

            michaelh Michael Hawkins
            michaelh Michael Hawkins
            Simey Lameze Simey Lameze
            Jun Pataleta Jun Pataleta
            Anna Carissa Sadia Anna Carissa Sadia
            Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 2 days, 3 hours, 13 minutes
                2d 3h 13m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.