-
Bug
-
Resolution: Fixed
-
Minor
-
3.9.2, 3.10, 3.11
-
MOODLE_310_STABLE, MOODLE_311_STABLE, MOODLE_39_STABLE
-
MOODLE_310_STABLE, MOODLE_39_STABLE
-
MDL-70034_master -
Following message doesn't get displayed on the advanced grading page when required.
'WARNING: Your marking guide has a maximum grade of <b>{$a->maxscore} points</b> but the maximum grade set in your activity is {$a->modulegrade} The maximum score set in your marking guide will be scaled to the maximum grade in the module.<br />
Intermediate scores will be converted respectively and rounded to the nearest available grade.'
Steps to replicate:
- Create a course
- Create a forum activity with Grade set to Point and Maximum grade = 50
- Set Grading method to Marking guide
- On advanced grading screen Define new grading from from scratch and create a couple of criterions with total max Score more than 50.
- Save marking guide and get it ready.
- On advanced grading screen:
expected: Warning message displayed
actual: no warning message displayed
This happens because for some reason forum activity has "grade_forum" field in "forum" table, but rest of the activities e.g. "lesson" or "assign" have it as "grade".
This breaks logic when we expect "grade" field to be available as part of "moduleinstance" object received here https://github.com/moodle/moodle/blob/master/grade/grading/form/guide/lib.php#L356
and used here https://github.com/moodle/moodle/blob/master/grade/grading/form/guide/renderer.php#L774
- caused a regression
-
MDL-70736 Unable to load Marking Guide Templates
- Closed